Skip to content

KAFKA-19285: Added more tests in SharePartitionManagerTest #19778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2025

Conversation

chirag-wadhwa5
Copy link
Contributor

@chirag-wadhwa5 chirag-wadhwa5 commented May 21, 2025

This PR includes more unit tests in the file SharePartitionManagerTest
to improve the coverage

Reviewers: Andrew Schofield [email protected]

@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) KIP-932 Queues for Kafka labels May 21, 2025
@apoorvmittal10 apoorvmittal10 added ci-approved and removed triage PRs from the community labels May 21, 2025
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have left some comments because the tests don't quite seem to be doing what is suggested.

assertInstanceOf(ShareSessionContext.class, context1);
assertFalse(((ShareSessionContext) context1).isSubsequent());

// The expected epoch from the share session should be 1, but we are passing 2. This should throw an exception.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we passing FINAL_EPOCH?

@AndrewJSchofield
Copy link
Member

@chirag-wadhwa5 Please merge latest changes.

Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Just one comment to tidy up the code remains.

@AndrewJSchofield AndrewJSchofield merged commit c398261 into apache:trunk May 28, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved core Kafka Broker KIP-932 Queues for Kafka tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants