-
Notifications
You must be signed in to change notification settings - Fork 14.4k
MINOR: Cleanups in Test Common Module #19775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @sjhajharia for this patch, left some comments
Could you update ClusterTemplate
L47 JavaDoc
...t-common-runtime/src/main/java/org/apache/kafka/common/test/junit/ClusterTestExtensions.java
Outdated
Show resolved
Hide resolved
.../test-common-runtime/src/test/java/org/apache/kafka/common/test/KafkaClusterTestKitTest.java
Outdated
Show resolved
Hide resolved
.../test-common-runtime/src/test/java/org/apache/kafka/common/test/KafkaClusterTestKitTest.java
Outdated
Show resolved
Hide resolved
Thanks @m1a2st for the review, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjhajharia thanks for this cleanup. one small comment is left. PTAL
...-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestExtensionsUnitTest.java
Show resolved
Hide resolved
Hey @chia7712 , |
you are right, Please ignore my previous comment 😢 |
No worries @chia7712 |
Now that Kafka Brokers support Java 17, this PR makes some changes in
test-common module. The changes mostly include:
Arrays.asList() are replaced with List.of()
with Map.of()
Reviewers: Ken Huang [email protected], Chia-Ping Tsai
[email protected]