-
Notifications
You must be signed in to change notification settings - Fork 14.7k
KAFKA-19174 Gradle version upgrade 8 -->> 9 #19513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9318bd3
4278e56
a6fe1c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,7 @@ runs: | |
distribution: temurin | ||
java-version: ${{ inputs.java-version }} | ||
- name: Setup Gradle | ||
uses: gradle/actions/setup-gradle@94baf225fe0a508e581a564467443d0e2379123b # v4.3.0 | ||
uses: gradle/actions/setup-gradle@748248ddd2a24f49513d8f472f81c3a07d4d50e1 # v4.4.4 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Version 5.0.0 has been released. As a follow-up, I will file a minor patch to revisit all actions |
||
env: | ||
GRADLE_BUILD_ACTION_CACHE_DEBUG_ENABLED: true | ||
with: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
#!/bin/sh | ||
|
||
# | ||
# Copyright © 2015-2021 the original authors. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have filed https://issues.apache.org/jira/browse/KAFKA-19756 to write down the correct steps for upgrading gradle |
||
# Copyright © 2015 the original authors. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
|
@@ -15,6 +15,8 @@ | |
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# | ||
# SPDX-License-Identifier: Apache-2.0 | ||
# | ||
|
||
############################################################################## | ||
# | ||
|
@@ -55,7 +57,7 @@ | |
# Darwin, MinGW, and NonStop. | ||
# | ||
# (3) This script is generated from the Groovy template | ||
# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt | ||
# https://github.com/gradle/gradle/blob/HEAD/platforms/jvm/plugins-application/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt | ||
# within the Gradle project. | ||
# | ||
# You can find Gradle at https://github.com/gradle/gradle/. | ||
|
@@ -84,7 +86,7 @@ done | |
# shellcheck disable=SC2034 | ||
APP_BASE_NAME=${0##*/} | ||
# Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036) | ||
APP_HOME=$( cd "${APP_HOME:-./}" > /dev/null && pwd -P ) || exit | ||
APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s\n' "$PWD" ) || exit | ||
chia7712 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
# Use the maximum available, or set MAX_FD != -1 to use that value. | ||
MAX_FD=maximum | ||
|
@@ -113,20 +115,6 @@ case "$( uname )" in #( | |
esac | ||
|
||
|
||
# Loop in case we encounter an error. | ||
for attempt in 1 2 3; do | ||
if [ ! -e "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" ]; then | ||
if ! curl -s -S --retry 3 -L -o "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" "https://raw.githubusercontent.com/gradle/gradle/v8.14.3/gradle/wrapper/gradle-wrapper.jar"; then | ||
rm -f "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" | ||
# Pause for a bit before looping in case the server throttled us. | ||
sleep 5 | ||
continue | ||
fi | ||
fi | ||
done | ||
|
||
CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar | ||
|
||
|
||
# Determine the Java command to use to start the JVM. | ||
if [ -n "$JAVA_HOME" ] ; then | ||
|
@@ -183,7 +171,6 @@ fi | |
# For Cygwin or MSYS, switch paths to Windows format before running java | ||
if "$cygwin" || "$msys" ; then | ||
APP_HOME=$( cygpath --path --mixed "$APP_HOME" ) | ||
CLASSPATH=$( cygpath --path --mixed "$CLASSPATH" ) | ||
|
||
JAVACMD=$( cygpath --unix "$JAVACMD" ) | ||
|
||
|
@@ -212,19 +199,31 @@ if "$cygwin" || "$msys" ; then | |
fi | ||
|
||
|
||
|
||
# Loop in case we encounter an error. | ||
for attempt in 1 2 3; do | ||
if [ ! -e "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" ]; then | ||
if ! curl -s -S --retry 3 -L -o "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" "https://raw.githubusercontent.com/gradle/gradle/v9.1.0/gradle/wrapper/gradle-wrapper.jar"; then | ||
rm -f "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" | ||
# Pause for a bit before looping in case the server throttled us. | ||
sleep 5 | ||
continue | ||
fi | ||
fi | ||
done | ||
|
||
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | ||
DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' | ||
|
||
# Collect all arguments for the java command: | ||
# * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, | ||
# * DEFAULT_JVM_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, | ||
# and any embedded shellness will be escaped. | ||
# * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be | ||
# treated as '${Hostname}' itself on the command line. | ||
|
||
set -- \ | ||
"-Dorg.gradle.appname=$APP_BASE_NAME" \ | ||
-classpath "$CLASSPATH" \ | ||
org.gradle.wrapper.GradleWrapperMain \ | ||
-jar "$APP_HOME/gradle/wrapper/gradle-wrapper.jar" \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change, introduced in gradle 8.14, seems to be a behavioral change. It causes a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I file the PR #20658 already. |
||
"$@" | ||
|
||
# Stop when "xargs" is not available. | ||
|
Uh oh!
There was an error while loading. Please reload this page.