KAFKA-17609:[4/4]Convert system tests to kraft part 4 #17328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Links to passing tests Streams smoke test |
bbejeck
force-pushed
the
KAFKA-17609_convert_system_tests_to_kraft_part_4
branch
from
487f524
to
00821d6
Compare
mjsax
reviewed
Oct 16, 2024
| @@ -49,8 +49,8 @@ def __init__(self, test_context): | |||
| @cluster(num_nodes=8) | |||
| @matrix(processing_guarantee=['exactly_once_v2', 'at_least_once'], | |||
| crash=[True, False], | |||
| metadata_quorum=quorum.all_non_upgrade) | |||
| def test_streams(self, processing_guarantee, crash, metadata_quorum=quorum.zk): | |||
| metadata_quorum=[quorum.combined_kraft]) | |||
There was a problem hiding this comment.
Can we remove metadata_quorum as parameter entirly ?
There was a problem hiding this comment.
Required to indicate to use KRaft for metadata quorum. Failing to do so without a @matrix annotation results in this error as the test will default to ZK without it.
zk_sasl=self.zk.zk_sasl if self.quorum_info.using_zk else False, zk_tls=self.zk_client_secure,
AttributeError: 'NoneType' object has no attribute 'zk_sasl'
mjsax
reviewed
Oct 16, 2024
| def test_rolling_upgrade_with_2_bounces(self, from_version): | ||
| @matrix(from_version=metadata_2_versions, metadata_quorum=[quorum.combined_kraft]) | ||
| @matrix(from_version=fk_join_versions, metadata_quorum=[quorum.combined_kraft]) | ||
| def test_rolling_upgrade_with_2_bounces(self, from_version, metadata_quorum): |
There was a problem hiding this comment.
Why are we adding metadata_quorum parameter? Seems unncessary?
There was a problem hiding this comment.
Required to indicate to use KRaft for metadata quorum. Failing to do so without a @matrix annotation results in this error as the test will default to ZK without it.
zk_sasl=self.zk.zk_sasl if self.quorum_info.using_zk else False, zk_tls=self.zk_client_secure,
AttributeError: 'NoneType' object has no attribute 'zk_sasl'
mjsax
reviewed
Oct 16, 2024
| @@ -245,7 +147,8 @@ def test_rolling_upgrade_with_2_bounces(self, from_version): | |||
| self.stop_and_await() | |||
|
|
|||
| @cluster(num_nodes=6) | |||
| def test_version_probing_upgrade(self): | |||
| @matrix(metadata_quorum=[quorum.combined_kraft]) | |||
| def test_version_probing_upgrade(self, metadata_quorum): | |||
mjsax
reviewed
Oct 16, 2024
| @matrix(from_version=[str(LATEST_3_2), str(DEV_VERSION)], upgrade=[True, False]) | ||
| def test_upgrade_downgrade_state_updater(self, from_version, upgrade): | ||
| @matrix(from_version=[str(LATEST_3_2), str(DEV_VERSION)], upgrade=[True, False], metadata_quorum=[quorum.combined_kraft]) | ||
| def test_upgrade_downgrade_state_updater(self, from_version, upgrade, metadata_quorum): |
mjsax
approved these changes
Oct 21, 2024
bbejeck
force-pushed
the
KAFKA-17609_convert_system_tests_to_kraft_part_4
branch
from
fe95ff6
to
1c3a33c
Compare
|
Link for passing tests in this PR
|
This reverts commit d49df48.
|
Merged #17328 into trunk |
3 tasks
abhishekgiri23
pushed a commit
to abhishekgiri23/kafka
that referenced
this pull request
Nov 2, 2024
Part 4 of 4 converting streams system tests to KRaft Reviewers: Matthias Sax <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)