KAFKA-17609:[3/4]Convert system tests to kraft part 3 #17327
Conversation
|
Links to passing tests Broker compatibility test is failing but seems unrelated to the changes for switching from ZK to KRaft |
bbejeck
force-pushed
the
KAFKA-17609_convert_system_tests_to_kraft_part_3
branch
from
ada336f
to
2d0494b
Compare
| @@ -86,7 +86,7 @@ def __init__(self, test_context): | |||
|
|
|||
| @cluster(num_nodes=8) | |||
| @matrix(crash=[False, True], | |||
| processing_guarantee=['exactly_once', 'exactly_once_v2'], | |||
| processing_guarantee=['exactly_once_v2'], | |||
There was a problem hiding this comment.
Given that we have only EOSv2 left, should we not just remove this parameter completely?
Given that exactly_once was remove from the code base a while ago already, I am wondering why we did not get any failing system test alerts? (Miss on my side to not remove this setting in one of my PRs) -- Or is this test not executed? 🤔
| @@ -86,7 +86,7 @@ def __init__(self, test_context): | |||
|
|
|||
| @cluster(num_nodes=8) | |||
| @matrix(crash=[False, True], | |||
| processing_guarantee=['exactly_once', 'exactly_once_v2'], | |||
| processing_guarantee=['exactly_once_v2'], | |||
| metadata_quorum=[quorum.isolated_kraft]) | |||
There was a problem hiding this comment.
Seem we can remove this parameter, too, and also switch to combined_kraft ?
| - Streams w/ EOS-v2 works for older brokers 2.5 (or newer) | ||
| - Streams fails fast for older brokers 0.10.0, 0.10.2, and 0.10.1 | ||
| - Streams w/ EOS-v2 fails fast for older brokers 2.4 or older |
There was a problem hiding this comment.
I am not sure why we would need any changes here? For compatibility testing, we should still be able to startup old Kafka with ZK and nothing should really change?
Of course, when using trunk/4.0 we would start brokers in kraft mode.
There was a problem hiding this comment.
My understanding was that all ZK was going to be completely removed maybe we can go with this as is and in a follow-up PR revisit and see what needs to be added back
There was a problem hiding this comment.
Let's clarify with @cmccabe before we merge this.
bbejeck
force-pushed
the
KAFKA-17609_convert_system_tests_to_kraft_part_3
branch
from
2d0494b
to
9c024d4
Compare
|
Link to passing tests.
|
This reverts commit d49df48.
|
Merged #17327 into trunk |
Part 3 of 4 converting streams system tests to KRaft Reviewers: Matthias Sax <[email protected]>
Committer Checklist (excluded from commit message)