-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-17258: Migrate AdminFenceProducersIntegrationTest to ClusterTestExtensions framework #17311
base: trunk
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mingyen066, Thanks for your PR, left some comments, PTAL
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mingyen066 thanks for your patch
core/src/test/java/kafka/admin/AdminFenceProducersIntegrationTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AdminFenceProducersIntegrationTest
from scala to java and withClusterTestExtensions
frameworkCommitter Checklist (excluded from commit message)