KAFKA-17646: Fix flaky KafkaStreamsTest.testStateGlobalThreadClose

[chenyulin0719]

It's regarding KAFKA-17646.

Two issues found in the flaky test:

1. Racing between streams.close() and shutdownHelper() threads: Resolved it by moving the streams.close() call after confirming the KafkaStreams state is in ERROR state.
2. Checking for short-lived PENDING_ERROR state: Resolved it by changing the assertion to check the log content State transition from RUNNING to PENDING_ERROR.

Put the verbose explanation under Jira comment.

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[chia7712]

@chenyulin0719 thanks for your patch. overall +1

[chenyulin0719]

@chia7712 Thanks for the review. I updated the PR as suggested.

[mjsax]

Thanks for the PR. One question. Won't we leak the thread if we don't join it?

[mjsax]

Why do we remove this line?

[chenyulin0719]

Hi @mjsax, there will be no GlobalStreamThread thread triggered since we mock the GlobalStreamThread.start() to change the state.

kafka/streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java

Lines 277 to 283 in 1854d4b

	doAnswer(invocation -> {
	globalThreadState.set(GlobalStreamThread.State.RUNNING);
	threadStateListenerCapture.getValue().onChange(mock,
	GlobalStreamThread.State.RUNNING,
	GlobalStreamThread.State.CREATED);
	return null;
	}).when(mock).start();

[mjsax]

Ah. Thanks! Missed this part.

[chia7712]

loop 200 times, all pass