KAFKA-17459: Stablize reassign_partitions_test.py #17250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankvicky
force-pushed
the
KAFKA-17459
branch
from
95b0014
to
f761342
Compare
|
Test result on my local machine (branch 3.9) |
chia7712
reviewed
Sep 23, 2024
There was a problem hiding this comment.
@frankvicky thanks for this fix. Could you please test this patch for 3.8 as we will have 3.8.1 release
| @@ -176,7 +176,7 @@ def test_reassign_partitions(self, bounce_brokers, reassign_from_offset_zero, me | |||
| self.producer = VerifiableProducer(self.test_context, self.num_producers, | |||
| self.kafka, self.topic, | |||
| throughput=self.producer_throughput, | |||
| enable_idempotence=True) | |||
| enable_idempotence=True, repeating_keys=100) | |||
There was a problem hiding this comment.
Could you please add comments?
|
Hello @chia7712 |
chia7712
reviewed
Sep 23, 2024
| enable_idempotence=True) | ||
| enable_idempotence=True, | ||
| # To avoid the reassignment behavior being affected by `partitioner.ignore.keys=true`, | ||
| # we set a key for the message to ensure the message order is preserved within the partition. |
There was a problem hiding this comment.
We need this change due to the test behavior, so it would be helpful to emphasize that point.
This test expects that each partition can receive the record, so using a non-null key helps distribute the records more randomly.
There was a problem hiding this comment.
Fair enough, I will add some context.
chia7712
reviewed
Sep 24, 2024
| enable_idempotence=True) | ||
| enable_idempotence=True, | ||
| # This test aims to verify the reassignment without failure, assuming that all partitions have data. | ||
| # To avoid the reassignment behavior being affected by `partitioner.ignore.keys=true`, |
There was a problem hiding this comment.
This description is not accurate as the default value of partitioner.ignore.keys is false, and the root cause is that the BuiltInPartitioner tries to send requests to the fast brokers.
Could you please keep the description "This test aims to verify the reassignment without failure, assuming that all partitions have data" and "we set a key for the message to ensure both even data distribution across all partitions"
There was a problem hiding this comment.
It seems that I have some misunderstanding before.
I have updated the comment, please take a look 😺
chia7712
pushed a commit
that referenced
this pull request
Sep 24, 2024
This test expects that each partition can receive the record, so using a non-null key helps distribute the records more randomly. Reviewers: Chia-Ping Tsai <[email protected]>
chia7712
pushed a commit
that referenced
this pull request
Sep 24, 2024
This test expects that each partition can receive the record, so using a non-null key helps distribute the records more randomly. Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: KAFKA-17459
Committer Checklist (excluded from commit message)