KAFKA-17650: validate ReplaceField config #17247
Conversation
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java
Outdated
Show resolved
Hide resolved
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java
Outdated
Show resolved
Hide resolved
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java
Outdated
Show resolved
Hide resolved
|
@TaiJuWu Could you please file a jira as it is a kind of bug |
TaiJuWu
changed the title
Done. Updated in title and post, thanks! |
|
@TaiJuWu why we need this changes? the other fields have no such checks. |
I noticed the check in the client-side module and believe it could also be applied to the connect module. |
that is a kind of behavior change. We need KIP if it is necessary improvement. |
| @@ -72,6 +73,10 @@ interface ConfigName { | |||
| .define(ConfigName.REPLACE_NULL_WITH_DEFAULT_CONFIG, ConfigDef.Type.BOOLEAN, true, ConfigDef.Importance.MEDIUM, | |||
| "Whether to replace fields that have a default value and that are null to the default value. When set to true, the default value is used, otherwise null is used."); | |||
|
|
|||
| private static Set<String> configNames() { | |||
There was a problem hiding this comment.
I note that ConfigName.RENAME actually has the value "renames" so it probably should be ConfigName.RENAMES. This probably ought to be resolved.
There was a problem hiding this comment.
@TaiJuWu Maybe you can file a minor PR to fix the naming. this PR needs more discussion due to behavior change.
There was a problem hiding this comment.
@TaiJuWu Maybe you can file a minor PR to fix the naming. this PR needs more discussion due to behavior change.
Will do, thanks for helping check.
jira: https://issues.apache.org/jira/browse/KAFKA-17650
There is no validation of ReplaceField, we should add it.
Committer Checklist (excluded from commit message)