KAFKA-16331: remove EOSv1 from StreamsProducer #17212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsax
commented
Sep 16, 2024
| @@ -203,11 +198,6 @@ public static Map<TopicPartition, ListOffsetsResultInfo> fetchEndOffsets(final C | |||
| return getEndOffsets(fetchEndOffsetsFuture(partitions, adminClient)); | |||
| } | |||
|
|
|||
| public static String extractThreadId(final String fullThreadName) { | |||
There was a problem hiding this comment.
side cleanup -- unused -- removing
mjsax
commented
Sep 16, 2024
| eosAlphaMockClientSupplier.setCluster(cluster); | ||
| eosAlphaMockClientSupplier.setApplicationIdForProducer("appId"); | ||
| eosAlphaStreamsProducer = | ||
| eosMockClientSupplier.setCluster(cluster); |
There was a problem hiding this comment.
Many EOS tests where not EOSv1 vs EOSv2 specific, but used eosAlphaXxx variables -- updating these to use eosBetaXxx (renamed to just eosXxxx) -- more of this below.
mjsax
commented
Sep 16, 2024
| @@ -191,7 +191,7 @@ public static <K, V> KeyValueStoreTestDriver<K, V> create(final Serializer<K> ke | |||
| private final Set<K> flushedRemovals = new HashSet<>(); | |||
| private final List<KeyValue<byte[], byte[]>> restorableEntries = new LinkedList<>(); | |||
|
|
|||
| private final InternalMockProcessorContext context; | |||
| private final InternalMockProcessorContext<?, ?> context; | |||
mjsax
commented
Sep 16, 2024
| @@ -266,7 +265,7 @@ public <K1, V1> void send(final String topic, | |||
| stateDir.mkdirs(); | |||
| stateSerdes = serdes; | |||
|
|
|||
| context = new InternalMockProcessorContext(stateDir, serdes.keySerde(), serdes.valueSerde(), recordCollector, null) { | |||
| context = new InternalMockProcessorContext<Object, Object>(stateDir, serdes.keySerde(), serdes.valueSerde(), recordCollector, null) { | |||
mjsax
commented
Sep 16, 2024
| @@ -447,7 +446,7 @@ private StreamTask createStreamsTask(final StreamsConfig streamsConfig, | |||
| topology | |||
| ); | |||
| final StreamsMetricsImpl streamsMetrics = new MockStreamsMetrics(metrics); | |||
| final InternalProcessorContext context = new ProcessorContextImpl( | |||
| final InternalProcessorContext<?, ?> context = new ProcessorContextImpl( | |||
mjsax
force-pushed
the
kafka-16331-eosv1-streamsproducer
branch
from
09744d7
to
32d8ae0
Compare
mjsax
changed the title
chia7712
reviewed
Sep 21, 2024
There was a problem hiding this comment.
@mjsax thanks for this patch. Could you please fix the build error:
[ant:checkstyle] [ERROR] /home/chia7712/project/kafka/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java:46:8: Unused import - org.apache.kafka.streams.processor.TaskId.
| @@ -318,14 +314,7 @@ Map<MetricName, Metric> producerMetrics() { | |||
| } | |||
|
|
|||
| Set<String> producerClientIds() { | |||
There was a problem hiding this comment.
Could we use String instead of Set<String>> for now?
There was a problem hiding this comment.
Yes, but not "completely". The ThreadMetadata interface is public API, and thus it's impl cannot be changed. I can include as much cleanup as possible thought.
Would need a KIP to change it -- not sure if worth doing at this point thought...
| @@ -191,7 +191,7 @@ public static <K, V> KeyValueStoreTestDriver<K, V> create(final Serializer<K> ke | |||
| private final Set<K> flushedRemovals = new HashSet<>(); | |||
| private final List<KeyValue<byte[], byte[]>> restorableEntries = new LinkedList<>(); | |||
|
|
|||
| private final InternalMockProcessorContext context; | |||
| private final InternalMockProcessorContext<?, ?> context; | |||
| private final StateSerdes<K, V> stateSerdes; | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
chia7712
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.