KAFKA-16550: add integration test for LogDirsCommand #16485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1a2st
reviewed
Jun 28, 2024
tools/src/test/java/org/apache/kafka/tools/LogDirsCommandTest.java
Outdated
Show resolved
Hide resolved
tools/src/test/java/org/apache/kafka/tools/LogDirsCommandTest.java
Outdated
Show resolved
Hide resolved
FrankYang0529
force-pushed
the
KAFKA-16550
branch
from
49b5018
to
4af149a
Compare
chia7712
reviewed
Jul 1, 2024
| } | ||
|
|
||
| @ClusterTest | ||
| public void testLogDirsWithSpecificTopic(ClusterInstance clusterInstance) { |
There was a problem hiding this comment.
Could you please add test to verify that it returns only the specific topic will get returned? for example, you can create another topic before testing.
| // check all log dirs and topic partitions are present | ||
| Map<Integer, Map<String, LogDirDescription>> logDirs = assertDoesNotThrow(() -> admin.describeLogDirs(clusterInstance.brokerIds()).allDescriptions().get()); | ||
| assertFalse(logDirs.isEmpty()); | ||
| logDirs.forEach((brokerId, logDirInfo) -> { |
| // check log dir and topic partition are present | ||
| Map<Integer, Map<String, LogDirDescription>> logDirs = assertDoesNotThrow(() -> admin.describeLogDirs(Collections.singleton(brokerId)).allDescriptions().get()); | ||
| assertEquals(1, logDirs.size()); | ||
| logDirs.forEach((brokerIdValue, logDirInfo) -> { |
| // check log dir is present, but topic partition is not | ||
| Map<Integer, Map<String, LogDirDescription>> logDirs = assertDoesNotThrow(() -> admin.describeLogDirs(clusterInstance.brokerIds()).allDescriptions().get()); | ||
| assertFalse(logDirs.isEmpty()); | ||
| logDirs.forEach((brokerId, logDirInfo) -> { |
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
KAFKA-16550
branch
from
4af149a
to
a22e217
Compare
|
Hi @chia7712, I address all comments. Could you take a look again? Thank you. |
chirag-wadhwa5
pushed a commit
to chirag-wadhwa5/kafka
that referenced
this pull request
Jul 3, 2024
Reviewers: Chia-Ping Tsai <[email protected]>
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration test cases for LogDirsCommand:
Committer Checklist (excluded from commit message)