KAFKA-16228: Add remote log metadata flag to the dump log tool #16475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the --remote-log-metadata-decoder flag to the kafka-dump-log.sh tool. This new flag can be used to decode the payload of the __remote_log_metadata records produced by the default RemoteLogMetadataManager. Signed-off-by: Federico Valeri <[email protected]>
divijvaidya
reviewed
Jul 2, 2024
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
showuon
reviewed
Jul 5, 2024
|
And thanks for adding these tests! |
Signed-off-by: Federico Valeri <[email protected]>
Signed-off-by: Federico Valeri <[email protected]>
|
@divijvaidya @showuon thanks for the reviews. Your comments should be addressed now. |
showuon
reviewed
Jul 5, 2024
Signed-off-by: Federico Valeri <[email protected]>
showuon
reviewed
Jul 5, 2024
Signed-off-by: Federico Valeri <[email protected]>
showuon
approved these changes
Jul 5, 2024
Signed-off-by: Federico Valeri <[email protected]>
divijvaidya
approved these changes
Jul 9, 2024
|
Failed tests are unrelated. |
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
…e#16475) This change adds the --remote-log-metadata-decoder flag to the kafka-dump-log.sh tool. This new flag can be used to decode the payload of the __remote_log_metadata records produced by the default RemoteLogMetadataManager. Reviewers: Luke Chen <[email protected]>, Divij Vaidya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
--remote-log-metadata-decoderflag to thekafka-dump-log.shtool. This new flag can be used to decode the payload of the__remote_log_metadatarecords produced by the defaultRemoteLogMetadataManager.