-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: Eliminate warnings for AdminUtils #16470
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
aec8cde
MINOR: Eliminate warnings for AdminUtils
LoganZhuZzz 73bca12
Merge branch 'apache:trunk' into trunk
LoganZhuZzz b2e3714
MINOR: Fix build issues
LoganZhuZzz c50d997
Merge branch 'apache:trunk' into trunk
LoganZhuZzz 6a3b3d5
MINOR: Original code is straightforward enough, revert and refactor.
LoganZhuZzz 2d06142
Merge branch 'apache:trunk' into trunk
LoganZhuZzz 1ad9d29
Merge branch 'apache:trunk' into trunk
LoganZhuZzz 87e1734
MINOR: Revert unrelated changes
LoganZhuZzz 1e35470
Merge branch 'apache:trunk' into trunk
LoganZhuZzz 6e36429
Merge branch 'apache:trunk' into trunk
LoganZhuZzz eaf9a5e
Merge branch 'apache:trunk' into trunk
LoganZhuZzz e2ff23c
MINOR: Add unit test for AdminUtils
LoganZhuZzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add UT for it?
AdminRackAwareTest
is a good class to have the new test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a new unit test for it. If there are any areas that could be improved, please provide me with some guidance and suggestions.