Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-17046: Upgrade netty version to 4.1.111.Final #16469

Merged
merged 2 commits into from
Jul 1, 2024
Merged

KAFKA-17046: Upgrade netty version to 4.1.111.Final #16469

merged 2 commits into from
Jul 1, 2024
+10 −10

Conversation

ulysses-you
Copy link
Contributor

The diff with netty 4.1.110.Final is:
netty/netty@netty-4.1.110.Final...netty-4.1.111.Final

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

m1a2st
m1a2st reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that need to update LICENSE-binary netty version

@ulysses-you
Copy link
Contributor Author

thank you @m1a2st , update LICENSE-binary to the latest version.

@m1a2st
Copy link
Contributor

m1a2st commented Jun 28, 2024 •
edited
Loading

LGTM, Gentle ping @chia7712, PTAL, Thanks

chia7712
chia7712 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712
Copy link
Contributor

@ulysses-you could you please rebase code to trigger QA again?

@ulysses-you
Copy link
Contributor Author

thank you @chia7712 for the reminder, rebased.

@chia7712 chia7712 merged commit 7d91bc8 into apache:trunk Jul 1, 2024
1 check failed
@ulysses-you
Copy link
Contributor Author

thank you @m1a2st @chia7712 !

@ulysses-you ulysses-you deleted the netty branch July 1, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chia7712 chia7712 chia7712 approved these changes

@m1a2st m1a2st m1a2st approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ulysses-you @m1a2st @chia7712