Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17045: Move MetadataLogConfig from kafka to kafka/raft #16468

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

ulysses-you
Copy link
Contributor

@ulysses-you ulysses-you commented Jun 27, 2024

The MetadataLogConfig belongs to raft, move file to raft to mach the package name.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ulysses-you
Copy link
Contributor Author

cc @jsancio @chia7712 if you have time to take a look, thank you.

@chia7712
Copy link
Contributor

chia7712 commented Jul 1, 2024

not sure whether it is good time to do this migration since KafkaMetadataLog is still in core module ..

@ulysses-you
Copy link
Contributor Author

@chia7712 yeah, but the MetadataLogConfig is also in core module, which means this pr only move the file from core/src/main/scala/kafka/MetadataLogConfig.scala to core/src/main/scala/kafka/raft/MetadataLogConfig.scala.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants