Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Fix transactions_upgrade_test to run transactions during upgrade #16462

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jolshan
Copy link
Contributor

@jolshan jolshan commented Jun 26, 2024

Move when the upgrade happens so we actually upgrade while transactio…ns are running

Copy link
Contributor

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming we got a successful run.

@jolshan
Copy link
Contributor Author

jolshan commented Jul 2, 2024

I couldn't get a fully successful run because KAFKA-17011 is still not closed in trunk. :(

@jolshan
Copy link
Contributor Author

jolshan commented Jul 11, 2024

Finally got to confirming the test results 👍 All passed. will merge now.

@jolshan jolshan merged commit e118811 into apache:trunk Jul 11, 2024
1 check failed
abhi-ksolves pushed a commit to ksolves/kafka that referenced this pull request Jul 31, 2024
…de (apache#16462)

Move when the upgrade happens so we actually upgrade while transactions are running

Reviewers: David Jacot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants