KAFKA-16730: Initial version of share group consumer client code #16461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lianetm
reviewed
Jul 4, 2024
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManager.java
Show resolved
Hide resolved
apoorvmittal10
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Thanks a lot for the PR @AndrewJSchofield. LGTM on the changes but I will rely on @lianetm and @kirktrue as they have the most context on the client design as per AsyncKafkaConsumer changes. I am sure we will be improving the functionality going forward and PR seems to provide the solid initial version for Share Consumers 👍
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AcknowledgementBatch.java
Outdated
Show resolved
Hide resolved
omkreddy
reviewed
Jul 10, 2024
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManagers.java
Outdated
Show resolved
Hide resolved
...ts/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java
Outdated
Show resolved
Hide resolved
...ts/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java
Outdated
Show resolved
Hide resolved
...ts/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java
Outdated
Show resolved
Hide resolved
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java
Outdated
Show resolved
Hide resolved
omkreddy
reviewed
Jul 11, 2024
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Acknowledgements.java
Outdated
Show resolved
Hide resolved
|
A handful of test failures, none of which are related to this PR. |
omkreddy
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
@AndrewJSchofield Thanks for the Initial version of share group consumer client code. LGTM. This is good starting point. I am sure, we will be adding more improvements/changes in the upcoming PRs.
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
…che#16461) This is the initial version of the share group consumer client code. It implements the complete ShareConsumer interface. There are unit tests, but not integration tests yet since those would depend upon complete broker code, which is not available at this point. Reviewers: Apoorv Mittal <[email protected]>, Manikumar Reddy <[email protected]>, Lianet Magrans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial version of the share group consumer client code. It implements the complete ShareConsumer interface.
There are unit tests, but not integration tests yet since those would depend upon complete broker code, which is not available at this point.
Committer Checklist (excluded from commit message)