KAFKA-17026: Implement updateCacheAndOffsets functionality on LSO movement #16459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adixitconfluent
force-pushed
the
kafka-17026
branch
2 times, most recently
from
4a844ef to
a11e394
Compare
apoorvmittal10
approved these changes
Jul 1, 2024
…ts in SharePartitionTest
adixitconfluent
force-pushed
the
kafka-17026
branch
from
815c7f7 to
d225e92
Compare
omkreddy
approved these changes
Jul 3, 2024
chirag-wadhwa5
pushed a commit
to chirag-wadhwa5/kafka
that referenced
this pull request
Jul 3, 2024
…ement (apache#16459) Implemented the functionality which takes care of archiving the records when LSO moves past them. Implemented the following functions - 1. updateCacheAndOffsets - Updates the cached state, start and end offsets of the share partition as per the new log start offset. The method is called when the log start offset is moved for the share partition. 2. archiveAvailableRecordsOnLsoMovement - This function archives all the available records when they are behind the LSO. 3. archivePerOffsetBatchRecords - It archives all the available records in the per offset tracked batch passed to this function. 4. archiveCompleteBatch - It archives all the available records of the complete batch passed to this function. Reviewers: Andrew Schofield <[email protected]>,Apoorv Mittal <[email protected]>, Manikumar Reddy <[email protected]>
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
…ement (apache#16459) Implemented the functionality which takes care of archiving the records when LSO moves past them. Implemented the following functions - 1. updateCacheAndOffsets - Updates the cached state, start and end offsets of the share partition as per the new log start offset. The method is called when the log start offset is moved for the share partition. 2. archiveAvailableRecordsOnLsoMovement - This function archives all the available records when they are behind the LSO. 3. archivePerOffsetBatchRecords - It archives all the available records in the per offset tracked batch passed to this function. 4. archiveCompleteBatch - It archives all the available records of the complete batch passed to this function. Reviewers: Andrew Schofield <[email protected]>,Apoorv Mittal <[email protected]>, Manikumar Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Implemented the functionality which takes care of archiving the records when LSO moves past them. Implemented the following functions -
updateCacheAndOffsets- Updates the cached state, start and end offsets of the share partition as per the new log start offset. The method is called when the log start offset is moved for the share partition.archiveAvailableRecordsOnLsoMovement- This function archives all the available records when they are behind the LSO.archivePerOffsetBatchRecords- It archives all the available records in the per offset tracked batch passed to this function.archiveCompleteBatch- It archives all the available records of the complete batch passed to this function.Testing
The added functionality has been tested with unit tests.
Suppression
In order for build to pass, I had to add JavaNCSS suppression for
SharePartitionTest. It takes into account the total lines of non-commented source code. Agreed, that we can optimize the currentSharePartitionTestcode at a few places, however, when we add new test cases, we will again breach this limit which is currently set at 1500. Hence, adding the suppression made sense to me.