MINOR: Revert unrelated changes

apache · Jun 28, 2024 · 87e1734 · 87e1734
1 parent 1ad9d29
commit 87e1734
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/server-common/src/main/java/org/apache/kafka/admin/AdminUtils.java b/server-common/src/main/java/org/apache/kafka/admin/AdminUtils.java
@@ -130,8 +130,6 @@ public static Map<Integer, List<Integer>> assignReplicasToBrokers(Collection<Bro
             return assignReplicasToBrokersRackUnaware(nPartitions, replicationFactor, brokerMetadatas.stream().map(b -> b.id).collect(Collectors.toList()), fixedStartIndex,
                 startPartitionId);
         else {
-            if (brokerMetadatas.stream().anyMatch(b -> !b.rack.isPresent()))
-                throw new AdminOperationException("Not all brokers have rack information for replica rack aware assignment.");
             return assignReplicasToBrokersRackAware(nPartitions, replicationFactor, brokerMetadatas, fixedStartIndex,
                 startPartitionId);
         }
@@ -166,7 +164,7 @@ private static Map<Integer, List<Integer>> assignReplicasToBrokersRackAware(int
                                                                                 int fixedStartIndex,
                                                                                 int startPartitionId) {
         Map<Integer, String> brokerRackMap = new HashMap<>();
-        brokerMetadatas.forEach(m -> brokerRackMap.put(m.id, m.rack.orElse(null)));
+        brokerMetadatas.forEach(m -> brokerRackMap.put(m.id, m.rack.orElseThrow(() -> new AdminOperationException("Not all brokers have rack information for replica rack aware assignment."))));
         int numRacks = new HashSet<>(brokerRackMap.values()).size();
         List<Integer> arrangedBrokerList = getRackAlternatedBrokerList(brokerRackMap);
         int numBrokers = arrangedBrokerList.size();