Support target database in write-back sink#18058
Open
Caideyipi wants to merge 4 commits into
Open
Conversation
jt2594838
reviewed
Jun 30, 2026
Comment on lines
+204
to
+207
| String.format( | ||
| "The table-model database %s is invalid. It should not contain '%s', should match " | ||
| + "the pattern %s, and the length should not exceed %d", | ||
| databaseName, PATH_SEPARATOR, IoTDBConfig.DATABASE_PATTERN, MAX_DATABASE_NAME_LENGTH), |
Comment on lines
+333
to
+350
| if (PathUtils.isTableModelDatabase(targetDatabase)) { | ||
| targetTableModelDatabaseName = targetDatabase.toLowerCase(Locale.ENGLISH); | ||
| targetTreeModelDatabaseName = | ||
| validateAndNormalizeTreeModelDatabaseName( | ||
| PathUtils.qualifyDatabaseName(targetTableModelDatabaseName)); | ||
| return; | ||
| } | ||
|
|
||
| targetTreeModelDatabaseName = validateAndNormalizeTreeModelDatabaseName(targetDatabase); | ||
| final String tableModelDatabaseName = | ||
| PathUtils.unQualifyDatabaseName(targetTreeModelDatabaseName).toLowerCase(Locale.ENGLISH); | ||
| try { | ||
| TableConfigTaskVisitor.validateDatabaseName(tableModelDatabaseName); | ||
| targetTableModelDatabaseName = tableModelDatabaseName; | ||
| } catch (final Exception e) { | ||
| invalidTargetTableModelDatabaseName = tableModelDatabaseName; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Why are tree db and table db set in both branches?
Comment on lines
+665
to
+667
| if (!startsWith(deviceNodes, sourceDatabaseNodes)) { | ||
| return devicePath; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
sink.database/connector.databasesupport for write-back sink data writes.root.requirement, legal tree path parsing, database-name pattern check, and length limit.root.target.db.root.a.bmapping to table databasea.b.Semantics
sink.database=targetis treated as a table-model database and mapped to tree databaseroot.targetfor tree writes.sink.database=root.targetandsink.database=root.target.dbare treated as tree-model databases.root.target.dbis valid for tree-model writes.root.target.dbistarget.db, which is invalid in table model and must reject table-model events.root.a.b/a.bare rejected.Validation
mvn spotless:apply -pl iotdb-core/datanodemvn spotless:apply -pl integration-test -P with-integration-testsgit diff --checkmvn -pl iotdb-core/datanode -Dtest=PipeSinkTest testwas attempted, but datanode compilation fails before test execution in existing generated Freemarker sources unrelated to this change, including missingIFill,IFillFilter,LinearFill,Accumulator,org.apache.commons.collections4.comparators, andIoTDBConfig#getModeMapSizeThreshold().