fix author procedure deserialize problem. #14675
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackieTien97
requested changes
Jan 17, 2025
| } catch (IOException e) { | ||
| LOGGER.error("IO error when deserialize authplan.", e); | ||
| } | ||
| if (byteBuffer.hasRemaining()) { |
There was a problem hiding this comment.
why removing this judgement? if you think this bytebuffer will always has remaining, you should add a else branch and then throw exeception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, fix auth plan loss when use simple consensus.
Because of the failure of authorProcedure, simple consensus will truncate some author action.