Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the logic of memtable flush controlled by memory series size #14591

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

HTHou
Copy link
Contributor

@HTHou HTHou commented Dec 30, 2024

In this PR, if the row number of a memory chunk exceeded the avgSeriesPointNumberThreshold, or the size of a binary type memory chunk exceeded the targetChunkSize, this memory chunk will split to multiple disk chunks in the TsFile.

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 81.62162% with 34 lines in your changes missing coverage. Please review.

Project coverage is 39.34%. Comparing base (263443d) to head (d06cc84).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...e/dataregion/memtable/AlignedWritableMemChunk.java 83.52% 14 Missing ⚠️
...geengine/dataregion/memtable/WritableMemChunk.java 82.14% 10 Missing ⚠️
...he/iotdb/db/utils/datastructure/AlignedTVList.java 69.56% 7 Missing ⚠️
...ageengine/dataregion/memtable/TsFileProcessor.java 66.66% 2 Missing ⚠️
...pache/iotdb/db/service/metrics/WritingMetrics.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #14591      +/-   ##
============================================
+ Coverage     39.28%   39.34%   +0.05%     
  Complexity      193      193              
============================================
  Files          4420     4420              
  Lines        281463   281443      -20     
  Branches      34806    34806              
============================================
+ Hits         110572   110732     +160     
+ Misses       170891   170711     -180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant