Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-11477][Issue Navigation] Add word boundary to improve the issue regex matching! #11477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adilattri
Copy link

@adilattri adilattri commented Nov 8, 2024

Used a word boundary(\b) to ensure that the number after INLONG- is matched perfectly or only matched.

Fixes #XYZ

Motivation

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

Used a word boundary(\b) to ensure that the number after INLONG- is matched perfectly or only matched.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @adilattri, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍

@adilattri
Copy link
Author

Added a word boundary so that the number after INLONG- is only matched , I hope my contribution gets merged.

@adilattri adilattri changed the title Update vcs.xml Addition of a word boundary(\b)! Nov 8, 2024
@adilattri adilattri changed the title Addition of a word boundary(\b)! [INLONG-XYZ][Issue Navigation] Add word boundary to improve the issue regex matching! Nov 8, 2024
@adilattri adilattri changed the title [INLONG-XYZ][Issue Navigation] Add word boundary to improve the issue regex matching! [INLONG-11477][Issue Navigation] Add word boundary to improve the issue regex matching! Nov 9, 2024
@dockerzhang
Copy link
Contributor

@adilattri please create an issue first, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants