verify-action-build: detect MATLAB platform-named binary dirs#850
Merged
Conversation
The in-tree binary detector flagged matlab-actions/run-tests@v3.1.1's
dist/bin/win64/run-matlab-command.exe (via .exe extension) but missed
the three Unix siblings under dist/bin/{glnxa64,maca64,maci64}/, which
have no extension and don't match the <name>-<os>-<arch> cross-compile
filename regex. Add a parent-directory rule for MATLAB's platform
identifiers so the Linux/macOS launchers are caught too, and pin a
regression test against the actual v3.1.1 shape.
Surfaced while triaging #846.
Generated-by: Claude Opus 4.7 (1M context)
ppkarwasz
approved these changes
May 18, 2026
Member
ppkarwasz
left a comment
ppkarwasz
left a comment
There was a problem hiding this comment.
LGTM, although having files in a folder called bin, seems like a pretty good hint that these are binary too.
Member
Author
Unless they are scripts :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_looks_like_in_tree_binaryflaggeddist/bin/win64/run-matlab-command.exe(via its.exe) but missed the three Unix siblings atdist/bin/{glnxa64,maca64,maci64}/run-matlab-command— they have no extension and don't fit the cross-compile<name>-<os>-<arch>regex.glnxa64,maca64,maci64), the file is treated as a launcher binary. Windows already worked via extension.matlab-actions/run-tests@v3.1.1shape so future bumps can't regress the catch.Surfaced while triaging #846 (upstream provenance ask: matlab-actions/run-tests#94).
Test plan
uv run pytest utils/tests/— 273 passedprek run --all-files— clean