-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#291] feat(client): Introduce PrefetchableClientReadHandler to support async read #2365
base: master
Are you sure you want to change the base?
Conversation
… support async read
cc @jerqi |
...age/src/main/java/org/apache/uniffle/storage/handler/impl/PrefetchableClientReadHandler.java
Outdated
Show resolved
Hide resolved
|
No, the real concurrency number is 1. |
Test Results 2 683 files - 298 2 683 suites - 298 5h 52m 50s ⏱️ - 35m 34s For more details on these failures and errors, see this check. Results for commit 0e3729a. ± Comparison against base commit e5cfc4a. ♻️ This comment has been updated with latest results. |
Could you add document for these config options? |
If the async fetch costs too much time, I hope the sync wait could recognize this case and then fast fail |
PrefetchTimeout may be equal to read time out. Isn't right? They are all the one time read max time. |
What changes were proposed in this pull request?
Why are the changes needed?
Recently I found some important spark jobs are slow due to the lots of shuffle read operations. If we could support async read, the job's performance will be improved.
So this PR is the callback for #291. almost 3 years ago!
Does this PR introduce any user-facing change?
Yes. Some configs are introduced
rss.client.read.prefetch.enabled
rss.client.read.prefetch.capacity
rss.client.read.prefetch.timeoutSec
How was this patch tested?