Skip to content

Conversation

@slievrly
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:

Fixes #890

make -n build

cd /tmp && mkdir test_dir && cd test_dir && echo "test" > VERSION && echo 'GIT_BRANCH=$(shell git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "unknown")\nGIT_REVISION=$(shell git rev-parse HEAD 2>/dev/null || echo "unknown")\nGO_FLAGS := -ldflags "-X main.Branch=$(GIT_BRANCH) -X main.Revision=$(GIT_REVISION)"\ntest:\n\t@echo "Branch: $(GIT_BRANCH)"\n\t@echo "Revision: $(GIT_REVISION)"\n\t@echo "Flags: $(GO_FLAGS)"' > Makefile && make test

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@github-actions github-actions bot added bug Something isn't working module/at labels Sep 24, 2025
@slievrly slievrly changed the title fix git status issue optimize: fix git status issue Sep 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.17%. Comparing base (190b3b9) to head (119b72b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   38.16%   38.17%   +0.01%     
==========================================
  Files         188      188              
  Lines       11417    11417              
==========================================
+ Hits         4357     4359       +2     
+ Misses       6629     6628       -1     
+ Partials      431      430       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

AlexStocks
AlexStocks previously approved these changes Sep 24, 2025
Copy link
Contributor

@Code-Fight Code-Fight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Code-Fight Code-Fight merged commit 4d2e765 into apache:master Nov 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working module/at

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Makefile Git Status Issue

4 participants