optimize: fix git status issue #894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #890
make -n build
cd /tmp && mkdir test_dir && cd test_dir && echo "test" > VERSION && echo 'GIT_BRANCH=$(shell git rev-parse --abbrev-ref HEAD 2>/dev/null || echo "unknown")\nGIT_REVISION=$(shell git rev-parse HEAD 2>/dev/null || echo "unknown")\nGO_FLAGS := -ldflags "-X main.Branch=$(GIT_BRANCH) -X main.Revision=$(GIT_REVISION)"\ntest:\n\t@echo "Branch:$(GIT_BRANCH)"\n\t@echo "Revision: $ (GIT_REVISION)"\n\t@echo "Flags: $(GO_FLAGS)"' > Makefile && make test
Special notes for your reviewer:
Does this PR introduce a user-facing change?: