This repository was archived by the owner on Jul 1, 2025. It is now read-only.
[NEMO-351] Empowering Nemo with fast I/O using Apache Crail #219
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,6 +51,7 @@ public enum Value { | |
| MemoryStore, | ||
| SerializedMemoryStore, | ||
| LocalFileStore, | ||
| GlusterFileStore, | ||
| CrailFileStore | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.nemo.compiler.optimizer.pass.compiletime.annotating; | ||
|
|
||
| import org.apache.nemo.common.ir.IRDAG; | ||
| import org.apache.nemo.common.ir.edge.IREdge; | ||
| import org.apache.nemo.common.ir.edge.executionproperty.DataStoreProperty; | ||
| import org.apache.nemo.compiler.optimizer.pass.compiletime.Requires; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| /** | ||
| * A pass to support Disaggregated Resources by tagging edges. | ||
| * This pass handles the DataStore ExecutionProperty. | ||
| */ | ||
| @Annotates(DataStoreProperty.class) | ||
| @Requires(DataStoreProperty.class) | ||
| public final class CrailEdgeDataStorePass extends AnnotatingPass { | ||
| /** | ||
| * Default constructor. | ||
| */ | ||
| public CrailEdgeDataStorePass() { | ||
| super(CrailEdgeDataStorePass.class); | ||
| } | ||
|
|
||
| @Override | ||
| public IRDAG apply(final IRDAG dag) { | ||
| dag.getVertices().forEach(vertex -> { // Initialize the DataStore of the DAG with CrailFileStore. | ||
| final List<IREdge> inEdges = dag.getIncomingEdgesOf(vertex); | ||
| inEdges.forEach(edge -> | ||
| edge.setPropertyPermanently(DataStoreProperty.of(DataStoreProperty.Value.CrailFileStore))); | ||
| }); | ||
| return dag; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.nemo.compiler.optimizer.policy; | ||
|
|
||
| import org.apache.nemo.common.ir.IRDAG; | ||
| import org.apache.nemo.compiler.optimizer.pass.compiletime.annotating.*; | ||
| import org.apache.nemo.compiler.optimizer.pass.compiletime.composite.DefaultCompositePass; | ||
| import org.apache.nemo.compiler.optimizer.pass.runtime.Message; | ||
|
|
||
| /** | ||
| * A policy to demonstrate the disaggregation optimization, that uses CrailFS as file storage. | ||
| */ | ||
| public final class CrailPolicy implements Policy { | ||
|
There was a problem hiding this comment. Can you add an integration test to test this policy? |
||
| public static final PolicyBuilder BUILDER = | ||
| new PolicyBuilder() | ||
| .registerCompileTimePass(new CrailEdgeDataStorePass()) | ||
| .registerCompileTimePass(new DefaultCompositePass()); | ||
| private final Policy policy; | ||
|
|
||
| /** | ||
| * Default constructor. | ||
| */ | ||
| public CrailPolicy() { | ||
| this.policy = BUILDER.build(); | ||
| } | ||
|
|
||
| @Override | ||
| public IRDAG runCompileTimeOptimization(final IRDAG dag, final String dagDirectory) { | ||
| return this.policy.runCompileTimeOptimization(dag, dagDirectory); | ||
| } | ||
|
|
||
| @Override | ||
| public IRDAG runRunTimeOptimizations(final IRDAG dag, final Message<?> message) { | ||
| return this.policy.runRunTimeOptimizations(dag, message); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,6 +76,21 @@ public final class FileDirectory implements Name<String> { | |
| public final class GlusterVolumeDirectory implements Name<String> { | ||
| } | ||
|
|
||
| /** Directory points the CrailFileStore volume used to store files in remote fashion. | ||
| * The directory has to be already created to give it as an option. (else exception is thrown) | ||
| */ | ||
| @NamedParameter(doc = "Directory points the CrailFS volume", short_name = "crail_dir", default_value = "") | ||
| public final class CrailVolumeDirectory implements Name<String> { | ||
| } | ||
|
|
||
| /** | ||
| * RemoteFileStore option specification. Two choices are available: GlusterFileStore or CrailFileStore. | ||
| * Default is the former one. | ||
| */ | ||
| @NamedParameter(doc = "Option for RemoteFileStore", short_name = "remote_option", default_value = "Gluster") | ||
| public final class RemoteFileStoreOpt implements Name<String> { | ||
|
There was a problem hiding this comment. Please remove this parameter. I think only the DataStoreProperty on the IR DAG should determine which store to use. I noticed the CrailFileStore property you added. |
||
| } | ||
|
|
||
| /** | ||
| * Specifies the type of the environment the workload runs on. (e.g., transient / large_shuffle) | ||
| */ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you file a new JIRA issue to convert JobConf parameters for directory paths (FileDirectory, GlusterVolumeDirectory, CrailVolumeDirectory) to DataStoreProperty parameters? To do this, the type of the possible values of the DataStoreProperty should also change from
enumtoclass.I suggest this change, because I think we should aim to integrate into the IR DAG as many configuration parameters as possible. Another benefit is that it saves the trouble of having to configure both JobConf and IR DAG to use a specific Crail/Gluster/File directory. Finally, this enables us to configure different directories for different IREdges.
A related issue is integrating the executor_json parameter into the IR DAG: https://issues.apache.org/jira/browse/NEMO-382