Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1547: DMN Editor: Render evaluation highlights in the Boxed Expression Editor #2681

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jomarko
Copy link
Contributor

@jomarko jomarko commented Oct 18, 2024

Closes: apache/incubator-kie-issues/issues/1547

checklist

  • decision table
  • conditional
  • context additional row
  • nested expressions

testing

You can test by update BeeTableBody in this way

find

  const { evaluationHitIds } = useBoxedExpressionEditor();

and replace it with BeeTableBody.tsx content from the gist:

Then you need to update also Base stories of the DecisionTable and Conditional using the same gist.

Decision Table

Screenshot 2024-10-30 131217

Conditional with nested expressions

image

@tiagobento tiagobento changed the title kie-issues#1547: Render evaluation highlights in the Boxed Expression… kie-issues#1547: Render evaluation highlights in the Boxed Expression Editor Oct 22, 2024
@@ -203,6 +203,46 @@
border: 0;
}

.expression-container .table-component tr.evaluation-highlights-row-overlay > td:first-child::before {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first-child here was my decision to use, otherwise there is problem, when then/ else branch has nested decision table, but not all decision table rules were evaluated. see:
Screenshot 2024-10-30 132337

@jomarko jomarko marked this pull request as ready for review October 30, 2024 15:11
@jomarko jomarko changed the title kie-issues#1547: Render evaluation highlights in the Boxed Expression Editor kie-issues#1547: DMN Editor: Render evaluation highlights in the Boxed Expression Editor Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants