Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducible build: Remove comments from quarkus generated properties files #3059

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Reproducible build: Remove comments from quarkus generated properties files #3059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a317bee
First draft of remove timestamps from comment
lucamolteni Jan 26, 2024
42c90dc
All files to be cleaned for reproducibility
lucamolteni Jan 29, 2024
fb128f5
Use ${version.maven-exec-plugin} instead of hardcoded version
lucamolteni Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions optaplanner-quarkus-integration/optaplanner-quarkus-benchmark/deployment/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,30 @@
</execution>
</executions>
</plugin>
<plugin>
<!-- Remove comments from META-INF/quarkus-extension.properties -->
<!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
<!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>${version.maven-exec-plugin}</version>
<executions>
<execution>
<id>Remove comments from quarkus-extension.properties</id>
<phase>prepare-package</phase>
<goals>
<goal>java</goal>
</goals>
<configuration>
<mainClass>org.drools.util.RemoveCommentsMain</mainClass>
<arguments>
<argument>${project.basedir}/target/classes/META-INF/quarkus-javadoc.properties</argument>
<argument>${project.basedir}/target/generated-sources/annotations/org/optaplanner/benchmark/quarkus/deployment/OptaPlannerBenchmarkBuildTimeConfig.jdp</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down
25 changes: 25 additions & 0 deletions optaplanner-quarkus-integration/optaplanner-quarkus-benchmark/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,31 @@
</execution>
</executions>
</plugin>
<plugin>
<!-- Remove comments from META-INF/quarkus-extension.properties -->
<!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
<!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>${version.maven-exec-plugin}</version>
<executions>
<execution>
<id>Remove comments from quarkus-extension.properties</id>
<phase>prepare-package</phase>
<goals>
<goal>java</goal>
</goals>
<configuration>
<mainClass>org.drools.util.RemoveCommentsMain</mainClass>
<arguments>
<argument>${project.basedir}/target/classes/META-INF/quarkus-extension.properties</argument>
<argument>${project.basedir}/target/classes/META-INF/quarkus-javadoc.properties</argument>
<argument>${project.basedir}/target/generated-sources/annotations/org/optaplanner/benchmark/quarkus/config/OptaPlannerBenchmarkRuntimeConfig.jdp</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
31 changes: 31 additions & 0 deletions optaplanner-quarkus-integration/optaplanner-quarkus-jackson/deployment/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,37 @@
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
<!-- Remove comments from META-INF/quarkus-extension.properties -->
<!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
<!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>${version.maven-exec-plugin}</version>
<dependencies>
<dependency>
<groupId>org.drools</groupId>
<artifactId>drools-util</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
<executions>
<execution>
<id>Remove comments from quarkus-extension.properties</id>
<phase>prepare-package</phase>
<goals>
<goal>java</goal>
</goals>
<configuration>
<includePluginDependencies>true</includePluginDependencies>
<mainClass>org.drools.util.RemoveCommentsMain</mainClass>
<arguments>
<argument>${project.basedir}/target/classes/META-INF/quarkus-javadoc.properties</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down
31 changes: 31 additions & 0 deletions optaplanner-quarkus-integration/optaplanner-quarkus-jackson/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,37 @@
</ignoredUnusedDeclaredDependencies>
</configuration>
</plugin>
<plugin>
<!-- Remove comments from META-INF/quarkus-extension.properties -->
<!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
<!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>${version.maven-exec-plugin}</version>
<dependencies>
<dependency>
<groupId>org.drools</groupId>
<artifactId>drools-util</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
<executions>
<execution>
<id>Remove comments from quarkus-extension.properties</id>
<phase>prepare-package</phase>
<goals>
<goal>java</goal>
</goals>
<configuration>
<includePluginDependencies>true</includePluginDependencies>
<mainClass>org.drools.util.RemoveCommentsMain</mainClass>
<arguments>
<argument>${project.basedir}/target/classes/META-INF/quarkus-extension.properties</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
31 changes: 31 additions & 0 deletions optaplanner-quarkus-integration/optaplanner-quarkus-jsonb/deployment/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,37 @@
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
<!-- Remove comments from META-INF/quarkus-extension.properties -->
<!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
<!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>${version.maven-exec-plugin}</version>
<dependencies>
<dependency>
<groupId>org.drools</groupId>
<artifactId>drools-util</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
<executions>
<execution>
<id>Remove comments from quarkus-extension.properties</id>
<phase>prepare-package</phase>
<goals>
<goal>java</goal>
</goals>
<configuration>
<includePluginDependencies>true</includePluginDependencies>
<mainClass>org.drools.util.RemoveCommentsMain</mainClass>
<arguments>
<argument>${project.basedir}/target/classes/META-INF/quarkus-javadoc.properties</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
31 changes: 31 additions & 0 deletions optaplanner-quarkus-integration/optaplanner-quarkus-jsonb/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,37 @@
</annotationProcessorPaths>
</configuration>
</plugin>
<plugin>
<!-- Remove comments from META-INF/quarkus-extension.properties -->
<!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
<!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>${version.maven-exec-plugin}</version>
<dependencies>
<dependency>
<groupId>org.drools</groupId>
<artifactId>drools-util</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
<executions>
<execution>
<id>Remove comments from quarkus-extension.properties</id>
<phase>prepare-package</phase>
<goals>
<goal>java</goal>
</goals>
<configuration>
<includePluginDependencies>true</includePluginDependencies>
<mainClass>org.drools.util.RemoveCommentsMain</mainClass>
<arguments>
<argument>${project.basedir}/target/classes/META-INF/quarkus-extension.properties</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
25 changes: 25 additions & 0 deletions optaplanner-quarkus-integration/optaplanner-quarkus/deployment/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,31 @@
</systemPropertyVariables>
</configuration>
</plugin>
<plugin>
<!-- Remove comments from META-INF/quarkus-javadoc.properties -->
<!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
<!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>${version.maven-exec-plugin}</version>
<executions>
<execution>
<id>Run Script</id>
<phase>prepare-package</phase>
<goals>
<goal>java</goal>
</goals>
<configuration>
<mainClass>org.drools.util.RemoveCommentsMain</mainClass>
<arguments>
<argument>${project.basedir}/target/classes/META-INF/quarkus-javadoc.properties</argument>
<argument>${project.basedir}/target/generated-sources/annotations/org/optaplanner/quarkus/deployment/config/OptaPlannerBuildTimeConfig.jdp</argument>
<argument>${project.basedir}/target/generated-sources/annotations/org/optaplanner/quarkus/deployment/config/SolverBuildTimeConfig.jdp</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

Expand Down
28 changes: 28 additions & 0 deletions optaplanner-quarkus-integration/optaplanner-quarkus/runtime/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,34 @@
</execution>
</executions>
</plugin>
<plugin>
<!-- Remove comments from META-INF/quarkus-extension.properties -->
<!-- This is needed because the file generated by quarkus contains a timestamp in a comment that makes the build not reproducible -->
<!-- This workaround can be removed when drools will be migrated to quarkus release containing this fix https://github.com/quarkusio/quarkus/pull/38365 -->
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>${version.maven-exec-plugin}</version>
<executions>
<execution>
<id>Remove comments from quarkus-extension.properties</id>
<phase>prepare-package</phase>
<goals>
<goal>java</goal>
</goals>
<configuration>
<mainClass>org.drools.util.RemoveCommentsMain</mainClass>
<arguments>
<argument>${project.basedir}/target/classes/META-INF/quarkus-extension.properties</argument>
<argument>${project.basedir}/target/classes/META-INF/quarkus-javadoc.properties</argument>
<argument>${project.basedir}/target/generated-sources/annotations/org/optaplanner/quarkus/config/OptaPlannerRuntimeConfig.jdp</argument>
<argument>${project.basedir}/target/generated-sources/annotations/org/optaplanner/quarkus/config/SolverManagerRuntimeConfig.jdp</argument>
<argument>${project.basedir}/target/generated-sources/annotations/org/optaplanner/quarkus/config/SolverRuntimeConfig.jdp</argument>
<argument>${project.basedir}/target/generated-sources/annotations/org/optaplanner/quarkus/config/TerminationRuntimeConfig.jdp</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
Loading