Make the build reproducible #624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucamolteni
approved these changes
Feb 5, 2024
|
Please do not merge yet. It has been brought up on Zulip that making this repo build reproducible might be unnecessary. The discussion is not yet closed. |
|
Closing. Making the quickstarts' build reproducible is necessary as the artifacts are not published and are not to be consumed as dependencies or deployed. The boiler-plate code required for the build reproducibility would only worsen the quickstart user experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicates changes from apache/incubator-kie-optaplanner#3059. The only new thing is the jandex plugin update to a version that supports reproducible builds.
Unfortunately, the quickstart POMs intentionally do not have a parent POM, so it's a lot of duplicated code. (Each quickstart is self-contained and easy to take out and modify. That's the reason for no parent POM.)
Contributes to apache/incubator-kie-issues#846.