[Incubator-kie-issues#1820] Resolve "Missing Conditional element" runtime exception during model execution #6257
Conversation
… into incubator-kie-issues#1820
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6257 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6257/2/display/redirect Test results:
Those are the test failures: org.kie.dmn.core.impl.DMNRuntimeEventManagerUtilsTest.testConditionalEventFailed to find file ConditionalEvent.dmn |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6257 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6257/4/display/redirect Test results:
Those are the test failures: org.kie.dmn.core.compiler.DMNEvaluatorCompilerTest.testCompileConditionalFailed to find file ConditionalEvent.dmnorg.kie.dmn.core.impl.DMNRuntimeEventManagerUtilsTest.testConditionalEventFailed to find file ConditionalEvent.dmn |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6257 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6257/5/display/redirect Test results:
Those are the test failures: org.kie.dmn.core.compiler.DMNEvaluatorCompilerTest.testCompileConditionalFailed to find file ConditionalEvent.dmnorg.kie.dmn.core.impl.DMNRuntimeEventManagerUtilsTest.testConditionalEventFailed to find file ConditionalEvent.dmn |
There was a problem hiding this comment.
Thanks for the PR, @AthiraHari77 !
There are minor things to be fixed, but anyway good job!
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/ast/DMNConditionalEvaluator.java
Outdated
Show resolved
Hide resolved
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/ast/DMNConditionalEvaluator.java
Outdated
Show resolved
Hide resolved
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/DMNEvaluatorCompiler.java
Outdated
Show resolved
Hide resolved
kie-dmn/kie-dmn-core/src/main/java/org/kie/dmn/core/compiler/DMNEvaluatorCompiler.java
Outdated
Show resolved
Hide resolved
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/ast/DMNConditionalEvaluatorTest.java
Outdated
Show resolved
Hide resolved
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/compiler/DMNEvaluatorCompilerTest.java
Outdated
Show resolved
Hide resolved
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/compiler/DMNEvaluatorCompilerTest.java
Outdated
Show resolved
Hide resolved
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/compiler/DMNEvaluatorCompilerTest.java
Show resolved
Hide resolved
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/compiler/DMNEvaluatorCompilerTest.java
Show resolved
Hide resolved
kie-dmn/kie-dmn-core/src/test/java/org/kie/dmn/core/impl/DMNRuntimeEventManagerUtilsTest.java
Show resolved
Hide resolved
|
@gitgabrio I have updated the PR with the changes requested. Please take a look. |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6257 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6257/8/display/redirect Test results:
Those are the test failures: org.kie.dmn.core.impl.DMNRuntimeEventManagerUtilsTest.fireAfterConditionalEvaluationdMNRuntimeEventListener.afterConditionalEvaluation( ); Wanted 1 time: -> at org.kie.dmn.api.core.event.DMNRuntimeEventListener.afterConditionalEvaluation(DMNRuntimeEventListener.java:61) But was 2 times: -> at org.kie.dmn.core.impl.DMNRuntimeEventManagerUtils.lambda$fireAfterConditionalEvaluation$15(DMNRuntimeEventManagerUtils.java:165) -> at org.kie.dmn.core.impl.DMNRuntimeEventManagerUtils.lambda$fireAfterConditionalEvaluation$15(DMNRuntimeEventManagerUtils.java:165) |
gitgabrio
changed the title
|
Thank you for this PR! |
yesamer
changed the title
…time exception during model execution (apache#6257) * [incubator-kie-issues#1820] Fix runtime exception during dmn model execution * [incubator-kie-issues#1820] Update test cases * [incubator-kie-issues#1820] Code refactoring * [incubator-kie-issues#1820] Fix header for dmn file * [incubator-kie-issues#1820] Fix test cases * [incubator-kie-issues#1820] Implement recursive retrieval of node by id * [incubator-kie-issues#1820] Code refactoring * [incubator-kie-issues#1820] Fix review comments * [incubator-kie-issues#1820] Fix test cases --------- Co-authored-by: athira <[email protected]> Co-authored-by: Gabriele-Cardosi <[email protected]>
Fixes apache/incubator-kie-issues#1820
This PR aims to fix the runtime exception "Missing Conditional element inside model" thrown while executing a dmn model which has a conditional event present.
How to retest this PR or trigger a specific build:
for pull request and downstream checks
for a full downstream build
run_fdbfor Jenkins PR check only
Build Nowbutton.