[NO-ISSUE] License check #6174
[NO-ISSUE] License check #6174
Conversation
- Remaining Category A license - Remove duplicate headers - Fix .rat-excludes
tkobayas
force-pushed
the
more-license-check
branch
from
b9e18bb
to
3a2989c
Compare
|
|
||
| ------------------------------------------------------------------------------------ | ||
| for drools-model/drools-canonical-model/src/main/java/org/drools/model/bitmask/OpenBitSet.java | ||
| drools-util/src/main/java/org/drools/util/bitmask/OpenBitSet.java |
There was a problem hiding this comment.
I'm not understanding why the Python license is necessary for our OpenBitSet, did we take the implementation from Python? Also is the whole history of Python really part of the license?
There was a problem hiding this comment.
Sorry that I didn't provide the information first.
* NOTE: this was originally borrowed from Python 2.4.2
* listobject.c sources (attribution in LICENSE.txt), but
* has now been substantially changed based on
* discussions from java-dev thread with subject "Dynamic
* array reallocation algorithms", started on Jan 12
* 2010.
I'm not sure how we should treat "borrowed" and "substantially changed" and it's just one method of the class.
@pjfanning Do we need to list this file as Python Software Foundation License? (although this is not urgent --- PSF is Category A)
is the whole history of Python really part of the license?
It's the content of the LICENSE.
https://github.com/python/cpython/blob/main/LICENSE
@pjfanning If we can drop the "history" part, please let me know.
There was a problem hiding this comment.
- if the code is borrowed then we need to include details about its LICENSE in our LICENSE
- this 'history' seems to be part of the LICENSE so we probably need to include it
- we could raise a LEGAL JIRA to discuss this but in mean time, it seems best to include full text of cpython license
LICENSE
Outdated
| for drools-util/src/main/java/org/drools/util/StringUtils.java | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); |
There was a problem hiding this comment.
* Borrowed from Spring, under the ASL2.0 license.
8 methods have this comment.
So I added this entry. I cannot find "copyright" of spring framework, so just noted the Apache License.
There was a problem hiding this comment.
I think it is best to mention Spring here. It means it is easier for people to track down the original source code.
Not urgent. This is not a blocker of 10.0.0