[10.0.x] Backport NOTICE and LISENSE refactoring and rat-excludes to 10.0.x #6167

tkobayas · 2024-11-21T03:34:28Z

Ports
Backport:

Issue:

notice file for drools is not correct incubator-kie-issues#1616

…apache#6149) * [incubator-kie-issues-1613] Add .rat-excludes file to each repository * removing apache-rat-plugin as we can check it with command line

…ache#6153) * [incubator-kie-issues-1616] notice file for drools is not correct * fix .rat-excludes * consolidate LICENSE files to single LICENSE file * fixed missing license header * fix CsvLineParser license * exclude drools-docs related licenses, because they will not be included in source distoribution

* [NO-ISSUE] mvel.jj license * - adjust words * - fixed a period

* adding OMG XSD files License info * fixing rat-excludes and adjusting file list of OMG files * adjusted trisotech related license and copyright info

tkobayas · 2024-11-21T05:59:58Z

LICENSE

+
+ ------------------------------------------------------------------------------------
+ for drools-model/drools-mvel-parser/src/main/javacc/mvel.jj
+     JavaParser is dual licensed under LGPL license and Apache License Version 2.0 license. We choose the Apache License Version 2.0.


LICENSE is a little different from main --- JavaParser.g4 and JavaLexer.g4 don't exist in 10.0.x.

tkobayas · 2024-11-21T06:00:52Z

@porcelli you wrote:

apache/incubator-kie-kogito-images#1811 (comment)

and for 10.0.0. release the individual repos content like .rat-exclude, DISCLAIMER, LEGAL, etc... will be removed for source anyway.

Backport of NOTICE etc. may not be required, but still license headers fixes are required (not sure if it's a blocker). Is it fine to merge this PR?

If this PR is not actually needed to get 10.0.0 released, feel free to close.

jomarko

Thank you for the PR. Some comments inline.

jomarko · 2024-11-21T09:49:47Z

NOTICE

-This product also includes the following third-party components:
-
-* lunr  2.3.9
-  Downloaded from: https://lunrjs.com/
-  License: MIT
-
-* search-ui
-  Downloaded from: https://gitlab.com/antora/antora-lunr-extension
-  License: Mozilla Public License 2.0
-
-* antora ui-bundle
-  Downloaded from: https://github.com/stephengold/antora-ui-bundle
-  License: Mozilla Public License 2.0


I think we need to add corresponding entries into LICENSE file, as the files are still delivered as part of apache-kie-10.0.0-incubating-sources.zip.

@jomarko Thank you for reviewing! These 3 components are placed under drools-docs, which will be excluded by the release CI starting with the next RC build, so we will not need to address them in LICENSE.

jomarko · 2024-11-21T09:54:11Z

.rat-excludes

+\.rat-excludes
+\.gitignore
+DISCLAIMER-WIP
+LICENSE-.*\.txt


I think we do not have such file LICENSE-.*\.txt

Thanks, I'll fix.

jomarko · 2024-11-21T09:54:36Z

.rat-excludes

+JavaLexer\.g4
+JavaParser\.g4


I think we do not have files with g4 extension

Thanks, I'll fix.

.rat-excludes

tkobayas · 2024-11-22T05:04:27Z

.rat-excludes

@@ -0,0 +1,338 @@
+# .git-blame-ignore-revs
+.git-blame-ignore-revs


Applied "list every single file" style to align with other repos. It's easier to review.

For main, filed #6169

tkobayas · 2024-11-22T05:05:17Z

.rat-excludes

+# DISCLAIMER-WIP
+DISCLAIMER-WIP
+# drools-decisiontables/src/main/java/org/drools/decisiontable/parser/csv/CsvLineParser.java
+CsvLineParser.java


CsvLineParser.java is listed in LICENSE

tkobayas · 2024-11-22T05:05:44Z

.rat-excludes

+# drools-docs/supplemental-ui/css/search.css
+search.css
+# drools-docs/supplemental-ui/js/search-ui.js
+search-ui.js
+# drools-docs/supplemental-ui/js/vendor/lunr-2.3.9.min.js
+lunr-2.3.9.min.js


drools-docs is excluded from the source distribution, so no need to check.

tkobayas · 2024-11-22T05:07:07Z

.rat-excludes

+# drools-model/drools-mvel-parser/src/main/javacc/mvel.jj
+mvel.jj


mvel.jj is listed in LICENSE

tkobayas · 2024-11-22T05:08:13Z

.rat-excludes

+# kie-dmn/kie-dmn-backend/src/test/resources/DC.xsd
+DC.xsd
+# kie-dmn/kie-dmn-backend/src/test/resources/DI.xsd
+DI.xsd
+# kie-dmn/kie-dmn-backend/src/test/resources/DMN11.xsd
+DMN11.xsd
+# kie-dmn/kie-dmn-backend/src/test/resources/DMN12.xsd
+DMN12.xsd
+# kie-dmn/kie-dmn-backend/src/test/resources/DMN13.xsd
+DMN13.xsd
+# kie-dmn/kie-dmn-backend/src/test/resources/DMN14.xsd
+DMN14.xsd
+# kie-dmn/kie-dmn-backend/src/test/resources/DMN15.xsd
+DMN15.xsd
+# kie-dmn/kie-dmn-backend/src/test/resources/DMNDI12.xsd
+DMNDI12.xsd
+# kie-dmn/kie-dmn-backend/src/test/resources/DMNDI13.xsd
+DMNDI13.xsd
+# kie-dmn/kie-dmn-backend/src/test/resources/DMNDI15.xsd
+DMNDI15.xsd


xsd files from OMG are listed in LICENSE

jomarko

@tkobayas thank you, I think last two comments/questions inline. I was focused for files, that ore not test files.

jomarko · 2024-11-22T05:37:51Z

.rat-excludes

+# drools-examples/src/main/resources/org/drools/examples/troubleticketWithDSL/TroubleTicketWithDSL.dslr
+TroubleTicketWithDSL.dslr


It seems this file support comments, are we sure we can not add license? Does added license break the build?

Thanks! Adding the headers and removing them from .rat-excludes

jomarko · 2024-11-22T05:42:19Z

.rat-excludes

+# kie-pmml-trusty/kie-pmml-compiler/kie-pmml-compiler-core/PMMLCompiler.uml
+PMMLCompiler.uml


I think it is just xml, would adding license as comment break the build?

Hi @gitgabrio , Could you confirm what license is applied to the PMMLCompiler.uml file? (e.g. what tool was used to export it. IntelliJ IDEA built-in tools?). Thanks!

At the moment, I assume that it's an usual output of IDE, I'm adding the apache license header.

tkobayas · 2024-11-22T08:05:07Z

Thank you @jomarko , I'll do the same fix to the main PR.

gitgabrio · 2024-11-22T08:28:32Z

Thanks @tkobayas
FYI, the PMMLCompiler.uml file already has the license header, in main.

jomarko

Thank you @tkobayas

tkobayas and others added 5 commits November 21, 2024 11:41

[incubator-kie-issues-1613] Add .rat-excludes file to each repository (…

6f82712

…apache#6149) * [incubator-kie-issues-1613] Add .rat-excludes file to each repository * removing apache-rat-plugin as we can check it with command line

[NO-ISSUE] mvel.jj license (apache#6164)

9a4cbd8

* [NO-ISSUE] mvel.jj license * - adjust words * - fixed a period

adding OMG XSD files License info (apache#6156)

35a9c57

* adding OMG XSD files License info * fixing rat-excludes and adjusting file list of OMG files * adjusted trisotech related license and copyright info

- adjust .rat-excludes

338fd3f

tkobayas commented Nov 21, 2024

View reviewed changes

tkobayas requested review from LightGuard, porcelli, baldimir and jomarko November 21, 2024 06:01

jomarko reviewed Nov 21, 2024

View reviewed changes

tkobayas added 2 commits November 21, 2024 19:25

adjust .rat-excludes

794e701

update .rat-excludes to list every single file

bd20b3b

tkobayas commented Nov 22, 2024

View reviewed changes

jomarko reviewed Nov 22, 2024

View reviewed changes

fix license headers

c8ea574

fix sysout

bdb880d

jomarko approved these changes Nov 22, 2024

View reviewed changes

tkobayas merged commit ff1fd93 into apache:10.0.x Nov 25, 2024
10 checks passed

tkobayas mentioned this pull request Nov 26, 2024

notice file for drools is not correct apache/incubator-kie-issues#1616

Closed

jomarko mentioned this pull request Nov 27, 2024

Add .rat-excludes file to each repository apache/incubator-kie-issues#1613

Open

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0.x] Backport NOTICE and LISENSE refactoring and rat-excludes to 10.0.x #6167

[10.0.x] Backport NOTICE and LISENSE refactoring and rat-excludes to 10.0.x #6167

tkobayas commented Nov 21, 2024

tkobayas Nov 21, 2024

tkobayas commented Nov 21, 2024 •

edited

Loading

jomarko left a comment

jomarko Nov 21, 2024

tkobayas Nov 21, 2024

jomarko Nov 22, 2024

jomarko Nov 21, 2024

tkobayas Nov 21, 2024

jomarko Nov 21, 2024

tkobayas Nov 21, 2024

tkobayas Nov 22, 2024 •

edited

Loading

tkobayas Nov 22, 2024

tkobayas Nov 22, 2024

tkobayas Nov 22, 2024

tkobayas Nov 22, 2024

jomarko left a comment

jomarko Nov 22, 2024

tkobayas Nov 22, 2024

jomarko Nov 22, 2024

tkobayas Nov 22, 2024

tkobayas Nov 22, 2024 •

edited

Loading

tkobayas commented Nov 22, 2024

gitgabrio commented Nov 22, 2024

jomarko left a comment

		@@ -0,0 +1,338 @@
		# .git-blame-ignore-revs
		.git-blame-ignore-revs

		# drools-model/drools-mvel-parser/src/main/javacc/mvel.jj
		mvel.jj

		# drools-examples/src/main/resources/org/drools/examples/troubleticketWithDSL/TroubleTicketWithDSL.dslr
		TroubleTicketWithDSL.dslr

		# kie-pmml-trusty/kie-pmml-compiler/kie-pmml-compiler-core/PMMLCompiler.uml
		PMMLCompiler.uml

		JavaLexer\.g4
		JavaParser\.g4

[10.0.x] Backport NOTICE and LISENSE refactoring and rat-excludes to 10.0.x #6167

[10.0.x] Backport NOTICE and LISENSE refactoring and rat-excludes to 10.0.x #6167

Conversation

tkobayas commented Nov 21, 2024

Choose a reason for hiding this comment

tkobayas commented Nov 21, 2024 • edited Loading

jomarko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tkobayas Nov 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jomarko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tkobayas Nov 22, 2024 • edited Loading

Choose a reason for hiding this comment

tkobayas commented Nov 22, 2024

gitgabrio commented Nov 22, 2024

jomarko left a comment

Choose a reason for hiding this comment

tkobayas commented Nov 21, 2024 •

edited

Loading

tkobayas Nov 22, 2024 •

edited

Loading

tkobayas Nov 22, 2024 •

edited

Loading