[GLUTEN-8432][CH]Remove duplicate output attributes of aggregate's child #8450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
lgbo-ustc
changed the title
|
Run Gluten Clickhouse CI on x86 |
|
It better to add some test cases for this scenario? |
|
Run Gluten ClickHouse CI on ARM |
1 similar comment
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
|
Run Gluten ClickHouse CI on ARM |
baibaichen
pushed a commit
to baibaichen/gluten
that referenced
this pull request
Feb 1, 2025
…ild (apache#8450) * Try to remove grouping keys in arguments of count(distinct) * adjust child's output in CHHashAggregateExecTransformer * update * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #8432
CH doesn' support duplicate columns in a block. Normally, there is no duplicate attributes in the output of an aggregate's child. There is one exception, when AQE is enabled, an shuffle resutl may be reused. If one of the aggregate function is
count(distinct)and its arguments contain the grouping keys, duplicate attributes would be introduced. And we cannot erase the duplicate attributes by #8164, since the rule cannot be applied.How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
manual tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)