Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN] VeloxCelebornColumnarBatchSerializer uses the key and default value of SHUFFLE_COMPRESS to check whether to compress shuffle output #6414

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

SteNicholas
Copy link
Member

@SteNicholas SteNicholas commented Jul 11, 2024

What changes were proposed in this pull request?

VeloxCelebornColumnarBatchSerializer uses the key and default value of SHUFFLE_COMPRESS to check whether to compress shuffle output.

How was this patch tested?

CI.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@SteNicholas SteNicholas changed the title [CELEBORN] ColumnarBatchSerializer uses the key and default value of SHUFFLE_COMPRESS to check whether to compress shuffle output [CELEBORN] VeloxCelebornColumnarBatchSerializer uses the key and default value of SHUFFLE_COMPRESS to check whether to compress shuffle output Jul 11, 2024
…ult value of SHUFFLE_COMPRESS to check whether to compress shuffle output
@SteNicholas
Copy link
Member Author

Ping @taiyang-li, @kerwin-zk, @ulysses-you.

@ulysses-you ulysses-you merged commit be6c8a1 into apache:main Jul 12, 2024
38 of 39 checks passed
yma11 added a commit to yma11/gluten that referenced this pull request Jul 15, 2024
…and default value of SHUFFLE_COMPRESS to check whether to compress shuffle output (apache#6414)"

This reverts commit be6c8a1.
yma11 added a commit to yma11/gluten that referenced this pull request Jul 15, 2024
…and default value of SHUFFLE_COMPRESS to check whether to compress shuffle output (apache#6414)"

This reverts commit be6c8a1.
yma11 added a commit to yma11/gluten that referenced this pull request Jul 15, 2024
…and default value of SHUFFLE_COMPRESS to check whether to compress shuffle output (apache#6414)"

This reverts commit be6c8a1.
yma11 added a commit to yma11/gluten that referenced this pull request Jul 15, 2024
…and default value of SHUFFLE_COMPRESS to check whether to compress shuffle output (apache#6414)"

This reverts commit be6c8a1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants