-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Supports register udf with different signatures #5104
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
1 similar comment
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
so, can this use the variable-length arguments in UDF? |
Run Gluten Clickhouse CI |
@liujp I'm afraid not. Will try to resolve it in another patch. |
@kecookier @zhouyuan Could you please help to review? Thanks! |
@PHILO-HE Could you help to review? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your great work!
issue #4988
Native side (UDF defination and registration)
Before: Only support specifying function name and return type in
UdfEntry
. After: Add 2 fieldsnumArgs
andargTypes
toUdfEntry
. Serialize both return type and arg types during registration from native to JVM.Java side (Resolving UDF expression)
Before: Create the
UDFExpression
based on the function name with the only supported return type. After: Get the registered return type based on function name and argument types. Create theUDFExpression
based on the function name and registered return type.