Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Supports register udf with different signatures #5104

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

marin-ma
Copy link
Contributor

@marin-ma marin-ma commented Mar 25, 2024

issue #4988

Native side (UDF defination and registration)

Before: Only support specifying function name and return type in UdfEntry. After: Add 2 fields numArgs and argTypes to UdfEntry. Serialize both return type and arg types during registration from native to JVM.

Java side (Resolving UDF expression)

Before: Create the UDFExpression based on the function name with the only supported return type. After: Get the registered return type based on function name and argument types. Create the UDFExpression based on the function name and registered return type.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@liujp
Copy link
Contributor

liujp commented Mar 26, 2024

so, can this use the variable-length arguments in UDF?

Copy link

Run Gluten Clickhouse CI

@marin-ma
Copy link
Contributor Author

so, can this use the variable-length arguments in UDF?

@liujp I'm afraid not. Will try to resolve it in another patch.

@marin-ma
Copy link
Contributor Author

@kecookier @zhouyuan Could you please help to review? Thanks!

@marin-ma
Copy link
Contributor Author

@PHILO-HE Could you help to review? Thanks!

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work!

@marin-ma marin-ma merged commit eb047b0 into apache:main Mar 26, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants