Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
ArnavBalyan committed Jan 17, 2025
1 parent 1c926f4 commit 7cc9590
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package org.apache.gluten.backendsapi.velox
import org.apache.gluten.GlutenConfig
import org.apache.gluten.backendsapi.RuleApi
import org.apache.gluten.columnarbatch.VeloxBatch
import org.apache.gluten.execution.ColumnarRangeExec
import org.apache.gluten.extension._
import org.apache.gluten.extension.columnar._
import org.apache.gluten.extension.columnar.MiscColumnarRules.{RemoveGlutenTableCacheColumnarToRow, RemoveTopmostColumnarToRow, RewriteSubqueryBroadcast}
Expand Down Expand Up @@ -150,7 +151,8 @@ object VeloxRuleApi {
RasOffload.from[LimitExec](OffloadOthers()),
RasOffload.from[GenerateExec](OffloadOthers()),
RasOffload.from[EvalPythonExec](OffloadOthers()),
RasOffload.from[SampleExec](OffloadOthers())
RasOffload.from[SampleExec](OffloadOthers()),
RasOffload.from[ColumnarRangeExec](OffloadOthers())
)
offloads.foreach(
offload =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,6 @@ abstract class RangeExecBaseTransformer(
outputAttributes
}

override protected def doValidateInternal(): ValidationResult = {
val isSupported = BackendsApiManager.getSettings.supportRangeExec()

if (!isSupported) {
return ValidationResult.failed(
s"RangeExec is not supported by the current backend."
)
}
ValidationResult.succeeded
}

override def rowType0(): Convention.RowType = Convention.RowType.None

override protected def doExecute()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ object Validators {
fail(p)
case p: CartesianProductExec if !settings.supportCartesianProductExec() => fail(p)
case p: TakeOrderedAndProjectExec if !settings.supportColumnarShuffleExec() => fail(p)
case p: RangeExec if !settings.supportRangeExec() => fail(p)
case _ => pass()
}
}
Expand Down

0 comments on commit 7cc9590

Please sign in to comment.