Skip to content

Conversation

petkostas
Copy link
Contributor

@petkostas petkostas commented Oct 1, 2025

Summary

  • Bump and align GO to version 1.23
  • Update failing linting issues
  • Pin golang-ci version

Does this close any open issues?

Closes #8584

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. component/framework This issue or PR relates to the framework improvement priority/medium This issue is medium important labels Oct 1, 2025
@spenpal
Copy link

spenpal commented Oct 3, 2025

This PR looks good to me. If possible, can you resolve the version issue with the go-dev-tools make command requiring Go 1.24?

@spenpal
Copy link

spenpal commented Oct 5, 2025

Another issue: When running make dep, I am get the following error:

go: github.com/golangci/golangci-lint/cmd/golangci-lint@latest: github.com/golangci/[email protected] requires go >= 1.23.0 (running go 1.22.12; GOTOOLCHAIN=local)

Do we need a higher version than Go 1.22? The last golangci-lint that supports Go 1.22 is v1.63.4, FYI. Currently, it is being set to latest in the backend Makefile.

@petkostas petkostas force-pushed the chore/8584-update-go branch from c0a09c8 to 258e964 Compare October 9, 2025 15:40
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 9, 2025
@petkostas petkostas force-pushed the chore/8584-update-go branch from b026f34 to 281fe9f Compare October 9, 2025 16:25
@petkostas
Copy link
Contributor Author

@spenpal going to 1.23 was a bit more tricky, but looks good now.

@petkostas petkostas changed the title chore(go): update go and align versions chore(go): update go version Oct 9, 2025
klesh
klesh previously approved these changes Oct 11, 2025
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to merge it when ready.

@spenpal
Copy link

spenpal commented Oct 14, 2025

Sorry for the late reply.

@klesh Is make go-dev-tools required for contributing to Apache Devlake? Because it requires Go 1.24.

make go-dev-tools
# go install github.com/atombender/go-jsonschema/cmd/gojsonschema@latest
go install golang.org/x/tools/cmd/goimports@latest
go: downloading golang.org/x/tools v0.38.0
go: golang.org/x/[email protected] requires go >= 1.24.0; switching to go1.24.9
go: downloading go1.24.9 (darwin/arm64)
go: downloading golang.org/x/telemetry v0.0.0-20251008203120-078029d740a8
go: downloading golang.org/x/mod v0.29.0
go install golang.org/x/tools/gopls@latest
go: golang.org/x/tools/[email protected] requires go >= 1.24.2; switching to go1.24.9
go install github.com/go-delve/delve/cmd/dlv@latest
go install honnef.co/go/tools/cmd/staticcheck@latest
go: honnef.co/go/[email protected] requires go >= 1.23; switching to go1.24.9

If it is, @petkostas we might need to update to Go 1.24 or downgrade go-dev-tools to use versions that support Go 1.23.

@petkostas petkostas force-pushed the chore/8584-update-go branch 2 times, most recently from 2295488 to 3dd2fa4 Compare October 15, 2025 15:42
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 15, 2025
- Bump golangci-lint for GO v1.24
@petkostas petkostas force-pushed the chore/8584-update-go branch from 3dd2fa4 to a9ec769 Compare October 15, 2025 15:50
@petkostas
Copy link
Contributor Author

@spenpal Updated to v1.24 please give it a GO (😄) again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/framework This issue or PR relates to the framework improvement priority/medium This issue is medium important size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Backend] Go version inconsistency between go.mod (1.20) and development environment (1.22)

3 participants