wip

apache · Mar 31, 2024 · 965fb22 · 965fb22
1 parent 30a8720
commit 965fb22
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 13 deletions.
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectImpl.java b/modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryObjectImpl.java
@@ -297,33 +297,25 @@ public BinaryObjectImpl detach(boolean checkCrossObjectReferences) {
 
         int len = length();
 
-        byte[] detachedData;
-
-        int detachedObjStartPos;
-
         if (checkCrossObjectReferences) {
             BinaryHeapInputStream in = BinaryHeapInputStream.create(arr, start);
 
             CrossObjectReferencesData crossObjReferencesData = CrossObjectReferenceDetector.collectCrossObjectReferencesData(in);
 
             if (!crossObjReferencesData.isEmpty()) {
                 try (BinaryOutputStream out = new BinaryHeapOutputStream(2 * len)) {
-                    detachedObjStartPos = CrossObjectReferenceResolver.resolveCrossObjectReferences(in, out, crossObjReferencesData);
+                    int detachedObjStartPos = CrossObjectReferenceResolver.resolveCrossObjectReferences(in, out, crossObjReferencesData);
 
-                    detachedData = out.arrayCopy();
-
-                    return new BinaryObjectImpl(ctx, detachedData, detachedObjStartPos);
+                    return new BinaryObjectImpl(ctx, out.arrayCopy(), detachedObjStartPos);
                 }
             }
         }
 
-        detachedObjStartPos = 0;
-
-        detachedData = new byte[len];
+        byte[] detachedData = new byte[len];
 
         U.arrayCopy(arr, start, detachedData, 0, len);
 
-        return new BinaryObjectImpl(ctx, detachedData, detachedObjStartPos);
+        return new BinaryObjectImpl(ctx, detachedData, 0);
     }
 
     /**

diff --git a/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinaryObjectsTestSuite.java b/modules/core/src/test/java/org/apache/ignite/testsuites/IgniteBinaryObjectsTestSuite.java
@@ -183,7 +183,7 @@
     BinaryContextPredefinedTypesTest.class,
 
     RawBytesObjectReaderTest.class,
-    CrossObjetReferenceSerializationTest.class
+    CrossObjetReferenceSerializationTest.class,
 })
 public class IgniteBinaryObjectsTestSuite {
 }