Skip to content

IGNITE-27498 Improve sendServerExceptionStackTraceToClient message #7345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptupitsyn merged 4 commits into from
Jan 7, 2026
Merged

IGNITE-27498 Improve sendServerExceptionStackTraceToClient message #7345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8360d13
IGNITE-27498 Improve sendServerExceptionStackTraceToClient message
ptupitsyn Jan 5, 2026
2d7dd3f
Fix checkstyle
ptupitsyn Jan 5, 2026
c541528
Fix checkstyle
ptupitsyn Jan 5, 2026
a91da32
Fix ItClientHandlerMetricsTest
ptupitsyn Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ void testBytesSentReceived(TestInfo testInfo) throws Exception {
ItClientHandlerTestUtils.connectAndHandshake(serverModule, false, true);

assertTrue(
IgniteTestUtils.waitForCondition(() -> testServer.metrics().bytesSent() == 304, 1000),
IgniteTestUtils.waitForCondition(() -> testServer.metrics().bytesSent() == 319, 1000),
() -> "bytesSent: " + testServer.metrics().bytesSent());

assertTrue(
Expand Down
19 changes: 15 additions & 4 deletions ...andler/src/integrationTest/java/org/apache/ignite/client/handler/ItClientHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,10 @@ void testHandshakeWithUnsupportedAuthenticationType() throws Exception {
"org.apache.ignite.security.exception.UnsupportedAuthenticationTypeException",
errClassName
);
assertEquals("To see the full stack trace set clientConnector.sendServerExceptionStackTraceToClient:true", errStackTrace);

assertEquals(
"To see the full stack trace, set clientConnector.sendServerExceptionStackTraceToClient:true on the server",
errStackTrace);
}
}

Expand Down Expand Up @@ -353,7 +356,9 @@ void testHandshakeWithAuthenticationInvalidCredentials() throws Exception {

assertThat(errMsg, containsString("Authentication failed"));
assertEquals("org.apache.ignite.security.exception.InvalidCredentialsException", errClassName);
assertEquals("To see the full stack trace set clientConnector.sendServerExceptionStackTraceToClient:true", errStackTrace);
assertEquals(
"To see the full stack trace, set clientConnector.sendServerExceptionStackTraceToClient:true on the server",
errStackTrace);
}
}

Expand Down Expand Up @@ -408,7 +413,10 @@ void testHandshakeWithAuthenticationEmptyCredentials() throws Exception {

assertThat(errMsg, containsString("Authentication failed"));
assertEquals("org.apache.ignite.security.exception.InvalidCredentialsException", errClassName);
assertEquals("To see the full stack trace set clientConnector.sendServerExceptionStackTraceToClient:true", errStackTrace);

assertEquals(
"To see the full stack trace, set clientConnector.sendServerExceptionStackTraceToClient:true on the server",
errStackTrace);
}
}

Expand Down Expand Up @@ -461,7 +469,10 @@ void testHandshakeInvalidVersionReturnsError() throws Exception {

assertThat(errMsg, containsString("Unsupported version: 2.8.0"));
assertEquals("org.apache.ignite.lang.IgniteException", errClassName);
assertEquals("To see the full stack trace set clientConnector.sendServerExceptionStackTraceToClient:true", errStackTrace);

assertEquals(
"To see the full stack trace, set clientConnector.sendServerExceptionStackTraceToClient:true on the server",
errStackTrace);
}
}

Expand Down
2 changes: 1 addition & 1 deletion ...t-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ private void writeErrorCore(Throwable err, ClientMessagePacker packer) {
if (configuration.sendServerExceptionStackTraceToClient()) {
packer.packString(ExceptionUtils.getFullStackTrace(pubErr));
} else {
packer.packString("To see the full stack trace set clientConnector.sendServerExceptionStackTraceToClient:true");
packer.packString("To see the full stack trace, set clientConnector.sendServerExceptionStackTraceToClient:true on the server");
}

// Extensions.
Expand Down
8 changes: 4 additions & 4 deletions ...rationTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientComputeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ void testIgniteExceptionInJobPropagatesToClientWithMessageAndCodeAndTraceIdAsync
assertNotNull(cause.getCause());
String hint = cause.getCause().getMessage();

assertEquals("To see the full stack trace set clientConnector.sendServerExceptionStackTraceToClient:true", hint);
assertEquals("To see the full stack trace, set clientConnector.sendServerExceptionStackTraceToClient:true on the server", hint);
}

@Test
Expand All @@ -456,7 +456,7 @@ void testIgniteExceptionInJobPropagatesToClientWithMessageAndCodeAndTraceIdSync(
assertNotNull(cause.getCause());
String hint = cause.getCause().getMessage();

assertEquals("To see the full stack trace set clientConnector.sendServerExceptionStackTraceToClient:true", hint);
assertEquals("To see the full stack trace, set clientConnector.sendServerExceptionStackTraceToClient:true on the server", hint);
}

@ParameterizedTest
Expand Down Expand Up @@ -660,7 +660,7 @@ private static void assertComputeExceptionWithClassAndMessage(IgniteException ca
assertNotNull(cause.getCause());
String hint = cause.getCause().getMessage();

assertEquals("To see the full stack trace set clientConnector.sendServerExceptionStackTraceToClient:true", hint);
assertEquals("To see the full stack trace, set clientConnector.sendServerExceptionStackTraceToClient:true on the server", hint);
}

private static void assertComputeExceptionWithStackTrace(IgniteException cause) {
Expand Down Expand Up @@ -892,7 +892,7 @@ <I, M, T> void testExecuteMapReduceExceptionPropagation(Class<? extends MapReduc
assertNotNull(cause.getCause());
String hint = cause.getCause().getMessage();

assertEquals("To see the full stack trace set clientConnector.sendServerExceptionStackTraceToClient:true", hint);
assertEquals("To see the full stack trace, set clientConnector.sendServerExceptionStackTraceToClient:true on the server", hint);
}
}

Expand Down
3 changes: 2 additions & 1 deletion ...ionTest/java/org/apache/ignite/internal/runner/app/client/ItThinClientConnectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ void testExceptionHasHint() {
.collect(Collectors.toList());

assertThat(causes,
hasItem(containsString("To see the full stack trace set clientConnector.sendServerExceptionStackTraceToClient:true")));
hasItem(containsString("To see the full stack trace, "
+ "set clientConnector.sendServerExceptionStackTraceToClient:true on the server")));
}

@Test
Expand Down