IGNITE-25789 Fix ConfigurationExtension nodeCreator ignoring key parameter #7329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PakhomovAlexander
force-pushed
the
ignite-25789
branch
3 times, most recently
from
12bfe88 to
da7279b
Compare
PakhomovAlexander
force-pushed
the
ignite-25789
branch
from
97db419 to
ea03db9
Compare
…meter 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
PakhomovAlexander
force-pushed
the
ignite-25789
branch
from
0d49e7c to
ee4f02d
Compare
…ults Add patchIfRootExists() to gracefully handle cases where configuration modules try to access roots that don't exist in a test SuperRoot when using custom rootName in @InjectConfiguration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
PakhomovAlexander
force-pushed
the
ignite-25789
branch
from
ee4f02d to
2e07e50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-25789
Summary
ConfigurationExtension.cfgValue()where thenodeCreatorlambda was ignoring its key parameterrootKeyregardless of which key was requestedrootKey.key()before creating the node🤖 Generated with Claude Code