Skip to content

chore(spec): remove stale #[allow(dead_code)] from snapshot_summary #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blackmwk merged 1 commit into from
May 28, 2026
+0 −4
Merged

chore(spec): remove stale #[allow(dead_code)] from snapshot_summary #2514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions crates/iceberg/src/spec/snapshot_summary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@ where T: PartialOrd + Default + ToString {
}
}

#[allow(dead_code)]
pub(crate) fn update_snapshot_summaries(
summary: Summary,
previous_summary: Option<&Summary>,
Expand Down Expand Up @@ -408,7 +407,6 @@ pub(crate) fn update_snapshot_summaries(
Ok(summary)
}

#[allow(dead_code)]
fn get_prop(previous_summary: &Summary, prop: &str) -> Result<i32> {
let value_str = previous_summary
.additional_properties
Expand All @@ -424,7 +422,6 @@ fn get_prop(previous_summary: &Summary, prop: &str) -> Result<i32> {
})
}

#[allow(dead_code)]
fn truncate_table_summary(mut summary: Summary, previous_summary: &Summary) -> Result<Summary> {
for prop in [
TOTAL_DATA_FILES,
Expand Down Expand Up @@ -481,7 +478,6 @@ fn truncate_table_summary(mut summary: Summary, previous_summary: &Summary) -> R
Ok(summary)
}

#[allow(dead_code)]
fn update_totals(
summary: &mut Summary,
previous_summary: Option<&Summary>,
Expand Down
Loading