feat(transaction): Remove current_table, updates, and requirements from Transaction #1451
+70
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTTY
commented
Jun 18, 2025
| for update in updates { | ||
| metadata_builder = update.clone().apply(metadata_builder)?; | ||
| } | ||
|
|
||
| self.current_table | ||
| .with_metadata(Arc::new(metadata_builder.build()?.metadata)); | ||
| table.with_metadata(Arc::new(metadata_builder.build()?.metadata)); |
There was a problem hiding this comment.
Not related to this pr, and it's not mandatory. But I think it's better to change the with_metadata(mut self) to consume table rather than modify it.
There was a problem hiding this comment.
this is a very good point. I did notice people are confused with the usage of tx.apply in other discussions, and making with_metadata consume tables would require tx.apply to return Result<Table> instead of Result<()> and make it clearer on its usage.
I've included the change in this PR, please let me know what you think!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related Issue
Closes:
What changes are included in this PR?
This PR wraps up the effort to make Transaction API + TransactionAction retryable!
With
Transactionholds retryableactions, it no longer needs to hold staging variables likecurrent_table,updates, orrequirements. These can be generated withindo_commit.Are these changes tested?
Existing unit tests