Skip to content

Fix the minio config #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2025
Merged

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Jun 6, 2025

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

mc config is deprecated minio/mc#5206

Similar to fix in iceberg-python and iceberg-go
apache/iceberg-python#2049
apache/iceberg-go#444

This PR also updates the image version of minio:minio and minio:mc to the latest available tag to pull in the change where mc config is deprecated.

Are these changes tested?

@kevinjqliu
Copy link
Contributor Author

Ah i was wondering why our CI wasn't failing. Looks like we were using a set image, others were using latest

image: minio/minio:RELEASE.2024-03-07T00-43-48Z

@kevinjqliu
Copy link
Contributor Author

I updated minio:minio and minio:mc images to the latest tag i can find

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for this pr!

@liurenjie1024 liurenjie1024 merged commit d8347c7 into apache:main Jun 7, 2025
17 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/minio-fix branch June 7, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants