Reject conflicted source-id and source-ids fields - #3645
Open
ebyhr wants to merge 1 commit into
Open
Conversation
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that's incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
rambleraptor
approved these changes
Aug 12, 2026
rambleraptor
left a comment
rambleraptor
left a comment
Collaborator
There was a problem hiding this comment.
I've got one small style nit, but otherwise this looks great.
| def map_source_ids_onto_source_id(cls, data: Any) -> Any: | ||
| if isinstance(data, dict): | ||
| if "source-id" not in data and "source-ids" in data: | ||
| if "source-ids" in data: |
Collaborator
There was a problem hiding this comment.
Suggested change
| if "source-ids" in data: | |
| if "source-ids" in data and "source-id" in data: | |
| raise ValueError("source-id and source-ids are mutually exclusive") | |
| elif "source-ids" in data: |
style nit. Nested if statements can confusing to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The original validator only ran multi-argument handling when
source-idwas absent (if "source-id" not in data and "source-ids" in data). When both keys were present,source-idswas silently ignored.Are these changes tested?
Yes
Are there any user-facing changes?
No.