feat: implement set snapshot #509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartLinked
changed the title
wgtmac
reviewed
Jan 14, 2026
HeartLinked
force-pushed
the
feat/set-snapshot
branch
from
9c831cb to
107cd63
Compare
wgtmac
requested changes
Jan 16, 2026
wgtmac
requested changes
Jan 16, 2026
|
|
||
| /// \brief Create a new SetSnapshot to set the current snapshot or rollback to a | ||
| /// previous snapshot and commit the changes. | ||
| virtual Result<std::shared_ptr<SetSnapshot>> NewSetSnapshot(); |
Member
There was a problem hiding this comment.
Please remove this since the Java impl only adds to transaction not table.
| class UpdateSchema; | ||
| class UpdateSortOrder; | ||
| class ExpireSnapshots; | ||
| class SetSnapshot; |
|
|
||
| std::optional<std::shared_ptr<Snapshot>> last_snapshot = std::nullopt; | ||
| ICEBERG_ASSIGN_OR_RAISE(auto ancestors, AncestorsOf(table, current)); | ||
| for (const auto& snapshot : ancestors) { |
| int64_t invalid_snapshot_id = 9999999999999999; | ||
| set_snapshot->SetCurrentSnapshot(invalid_snapshot_id); | ||
|
|
||
| // Should fail during Apply |
Member
There was a problem hiding this comment.
Suggested change
| // Should fail during Apply |
| // Rollback to the oldest snapshot (which is an ancestor) | ||
| set_snapshot->RollbackTo(kOldestSnapshotId); | ||
|
|
||
| // Apply and verify |
Member
There was a problem hiding this comment.
Suggested change
| // Apply and verify |
| TEST_F(SetSnapshotTest, RollbackToTimeExactMatch) { | ||
| ICEBERG_UNWRAP_OR_FAIL(auto set_snapshot, table_->NewSetSnapshot()); | ||
| // Rollback to a timestamp just after the oldest snapshot | ||
| // This should return the oldest snapshot (the latest one before this time) |
Member
There was a problem hiding this comment.
Suggested change
| // This should return the oldest snapshot (the latest one before this time) |
Comment on lines
+143
to
+146
| // Apply without making any changes (NOOP) | ||
| ICEBERG_UNWRAP_OR_FAIL(auto snapshot_id, set_snapshot->Apply()); | ||
|
|
||
| // Should return current snapshot |
Member
There was a problem hiding this comment.
Suggested change
| // Apply without making any changes (NOOP) | |
| ICEBERG_UNWRAP_OR_FAIL(auto snapshot_id, set_snapshot->Apply()); | |
| // Should return current snapshot | |
| ICEBERG_UNWRAP_OR_FAIL(auto snapshot_id, set_snapshot->Apply()); |
| // Should return current snapshot | ||
| EXPECT_EQ(snapshot_id, kCurrentSnapshotId); | ||
|
|
||
| // Commit NOOP and verify nothing changed |
Member
There was a problem hiding this comment.
Suggested change
| // Commit NOOP and verify nothing changed |
| } | ||
| auto current_timestamp = snapshot->timestamp_ms; | ||
| if (current_timestamp < target_timestamp && current_timestamp > latest_timestamp) { | ||
| latest_timestamp = current_timestamp; // Save timestamp before move |
Member
There was a problem hiding this comment.
I think this function can return Result<std::optional<int64_t> now.
Comment on lines
+107
to
+108
| auto current_result = metadata.Snapshot(); | ||
| ICEBERG_ACTION_FOR_NOT_FOUND(current_result, return {}); |
Member
There was a problem hiding this comment.
Shouldn't we return the error as is if current snapshot is missing? The current approach may confuse the caller that the current snapshot exists but it does not have any ancestor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.