refactor: Restructure catalog module #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeartLinked
force-pushed
the
feat/catalog-rest1
branch
from
de1206b to
5c4d0d1
Compare
HeartLinked
force-pushed
the
feat/catalog-rest1
branch
8 times, most recently
from
b03771f to
681c18a
Compare
HeartLinked
changed the title
HeartLinked
changed the title
HeartLinked
force-pushed
the
feat/catalog-rest1
branch
5 times, most recently
from
3338363 to
e7db68e
Compare
wgtmac
requested changes
Sep 29, 2025
wgtmac
reviewed
Sep 29, 2025
| @@ -15,13 +15,23 @@ | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
|
|
|||
| fetchcontent_declare(cpp-httplib | |||
There was a problem hiding this comment.
@WillAyd Do you have any comment?
There was a problem hiding this comment.
Assuming this is in the context of Meson then no - this package is available in the wrapdb so it's easy to integrate
wgtmac
reviewed
Sep 29, 2025
| # under the License. | ||
|
|
||
| iceberg_install_all_headers(iceberg/catalog) | ||
| add_subdirectory(memory) |
There was a problem hiding this comment.
Suggested change
| add_subdirectory(memory) | |
| add_subdirectory(memory) |
HeartLinked
force-pushed
the
feat/catalog-rest1
branch
from
843a775 to
957f9d7
Compare
wgtmac
approved these changes
Oct 10, 2025
Fokko
approved these changes
Oct 10, 2025
WillAyd
reviewed
Oct 10, 2025
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| iceberg_install_all_headers(iceberg/catalog) |
There was a problem hiding this comment.
FYI since the in_memory_catalog.h header was moved, this no longer installs anything. Maybe worth removing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganizes the catalog module structure to better support the upcoming REST catalog implementation. Changes:
memorysubdirectory withiniceberg-cpp/src/iceberg/catalog/. Move the existingin_memory_catalog.ccandin_memory_catalog.hfiles into this new memory subdirectory.jsondependencies for the rest package to support serialization and deserialization of data.cpp-httplibdependency to the rest test code. This library will be used to simply simulate an Iceberg REST server, enabling tests of whether the RestCatalog client can communicate with it correctly and handle success and failure scenarios.Hint:
closes #229 .