fix: Use explicit Throwable type in AvroConversionUtils catch clause#18342
Merged
voonhous merged 1 commit intoapache:masterfrom Mar 19, 2026
Merged
Conversation
Collaborator
a52a850 to
64be4ac
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18342 +/- ##
============================================
- Coverage 68.48% 68.48% -0.01%
+ Complexity 27362 27359 -3
============================================
Files 2420 2420
Lines 132127 132127
Branches 15909 15909
============================================
- Hits 90491 90488 -3
+ Misses 34627 34626 -1
- Partials 7009 7013 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
voonhous
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue this Pull Request addresses
The bare
case e =>inAvroConversionUtils.scala:70catches all Throwables implicitly, triggering a Scala compiler warning.Summary and Changelog
This PR makes the intent explicit with
case e: Throwable =>to silence the warning without changing behaviorImpact
Addressed build warning
Risk Level
none
Documentation Update
none
Contributor's checklist