Skip to content

fix: Use explicit Throwable type in AvroConversionUtils catch clause#18342

Merged
voonhous merged 1 commit intoapache:masterfrom
yihua:fix/avro-conversion-explicit-throwable-catch
Mar 19, 2026
Merged

fix: Use explicit Throwable type in AvroConversionUtils catch clause#18342
voonhous merged 1 commit intoapache:masterfrom
yihua:fix/avro-conversion-explicit-throwable-catch

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Mar 18, 2026

Describe the issue this Pull Request addresses

The bare case e => in AvroConversionUtils.scala:70 catches all Throwables implicitly, triggering a Scala compiler warning.

Summary and Changelog

This PR makes the intent explicit with case e: Throwable => to silence the warning without changing behavior

Impact

Addressed build warning

Risk Level

none

Documentation Update

none

Contributor's checklist

  • Read through contributor's guide
  • Enough context is provided in the sections above
  • Adequate tests were added if applicable

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Mar 18, 2026
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua force-pushed the fix/avro-conversion-explicit-throwable-catch branch from a52a850 to 64be4ac Compare March 18, 2026 18:27
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.48%. Comparing base (14a549f) to head (64be4ac).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18342      +/-   ##
============================================
- Coverage     68.48%   68.48%   -0.01%     
+ Complexity    27362    27359       -3     
============================================
  Files          2420     2420              
  Lines        132127   132127              
  Branches      15909    15909              
============================================
- Hits          90491    90488       -3     
+ Misses        34627    34626       -1     
- Partials       7009     7013       +4     
Flag Coverage Δ
common-and-other-modules 44.37% <100.00%> (+<0.01%) ⬆️
hadoop-mr-java-client 45.16% <ø> (+0.05%) ⬆️
spark-client-hadoop-common 48.33% <0.00%> (+<0.01%) ⬆️
spark-java-tests 48.91% <100.00%> (ø)
spark-scala-tests 45.11% <100.00%> (-0.01%) ⬇️
utilities 38.70% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...in/scala/org/apache/hudi/AvroConversionUtils.scala 97.05% <100.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@voonhous voonhous merged commit 19c4cc9 into apache:master Mar 19, 2026
109 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS PR with lines of changes in <= 10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants