[HUDI-8798] Validate Metadata Table Enabled during Archival #12549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamsikarnika
commented
Jan 6, 2025
Comment on lines
+298
to
+300
| if (enableMetadata) { | ||
| disableMetadataTable(writeConfig); | ||
| } |
There was a problem hiding this comment.
We're disabling metadata table after few commits are made, metadata table partitions should already be presnet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Add a check in HoodieTimelineArchiver to validate if metadata table is enabled for the table.
Impact
Only queries metadata table if it's enabled for the table. Previously we're relying on the presence of the file partitions present in the metadata table. If metadata table is disabled for the stream after a while, we'd still have the partitions present. We need this check to validate if metadata table is enabled for the stream.
Risk level (write none, low medium or high below)
None
Adds extra check to see if metadata table is enabled.
Documentation Update
NA
Contributor's checklist