Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-8794] Make sure the log file has been closed and then remove the shutdown hook #12542

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TheR1sing3un
Copy link
Member

In our actual production, we encountered an exception because the log file was not closed and then subsequent tasks to read the file.

Consider the following scenario: A speculative task has finished writing all the data, but the original task has been successfully executed, resulting in the need to kill the task. In the exit logic, we find that the code will remove the shutdown hook and then execute the close. If a jvm exits between the shutdown removal and the close completion, the log file will not be closed properly, resulting in a downstream read error.

org.apache.hudi.common.table.log.HoodieLogFormatWriter#close
image

Change Logs

  1. make sure log file has been closed and then remove the shutdown hook

Describe context and summary for this change. Highlight if any code was copied.

Impact

none
Describe any public API or user-facing feature change or any performance impact.

Risk level (write none, low medium or high below)

low
If medium or high, explain what verification was done to mitigate the risks.

Documentation Update

none
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

…hook

1. make sure log file has been closed and then remove the shutdown hook

Signed-off-by: TheR1sing3un <[email protected]>
@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Dec 26, 2024
@hudi-bot
Copy link

hudi-bot commented Jan 2, 2025

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S PR with lines of changes in (10, 100]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants